gem5-dev@gem5.org

The gem5 Developer List

View all threads

[XS] Change in gem5/gem5[develop]: stdlib: small fix in spec-2006 and spec-2007

HJ
humza jahangir ikram (Gerrit)
Fri, Apr 7, 2023 7:47 PM

humza jahangir ikram has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/69537?usp=email )

Change subject: stdlib: small fix in spec-2006 and spec-2007
......................................................................

stdlib: small fix in spec-2006 and spec-2007

I modified the spec-2017 benchmark file to include a
processor.switch() statement (which had been removed
in an earlier commit). I also replaced the use of
get_roi_ticks() with get_tick_stopwatch() as this
particular workload is not annotated with "workbegin"
and "workend" annotations.

Lastly, I fixed a minor bug in the spec-2006 file
which printed the total simulated ticks as zero due
to incorrect indexing of get_tick_stopwatch().

Change-Id: If0b6f88d6701a11f32e2e69994582524e0d7097b

M configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
M configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
b/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
index e7a9e82..60d93eb 100644
--- a/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
+++ b/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
@@ -306,7 +306,7 @@
print("Performance statistics:")

roi_begin_ticks = simulator.get_tick_stopwatch()[0][1]
-roi_end_ticks = simulator.get_tick_stopwatch()[0][1]
+roi_end_ticks = simulator.get_tick_stopwatch()[1][1]

print("roi simulated ticks: " + str(roi_end_ticks - roi_begin_ticks))

diff --git a/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
b/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
index 531ce94..c491c9b 100644
--- a/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
+++ b/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
@@ -288,6 +288,7 @@
print("Done bootling Linux")
print("Resetting stats at the start of ROI!")
m5.stats.reset()

  • processor.switch()
    yield False  # E.g., continue the simulation.
    print("Dump stats at the end of the ROI!")
    m5.stats.dump()
    @@ -319,7 +320,11 @@
    print()
    print("Performance statistics:")

-print("Simulated time in ROI: " + ((str(simulator.get_roi_ticks()[0]))))
+roi_begin_ticks = simulator.get_tick_stopwatch()[0][1]
+roi_end_ticks = simulator.get_tick_stopwatch()[1][1]
+
+print("roi simulated ticks: " + str(roi_end_ticks - roi_begin_ticks))
+
print(
"Ran a total of", simulator.get_current_tick() / 1e12, "simulated
seconds"
)

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/69537?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: If0b6f88d6701a11f32e2e69994582524e0d7097b
Gerrit-Change-Number: 69537
Gerrit-PatchSet: 1
Gerrit-Owner: humza jahangir ikram humzajahangirikram@gmail.com
Gerrit-MessageType: newchange

humza jahangir ikram has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/69537?usp=email ) Change subject: stdlib: small fix in spec-2006 and spec-2007 ...................................................................... stdlib: small fix in spec-2006 and spec-2007 I modified the spec-2017 benchmark file to include a processor.switch() statement (which had been removed in an earlier commit). I also replaced the use of get_roi_ticks() with get_tick_stopwatch() as this particular workload is not annotated with "workbegin" and "workend" annotations. Lastly, I fixed a minor bug in the spec-2006 file which printed the total simulated ticks as zero due to incorrect indexing of get_tick_stopwatch(). Change-Id: If0b6f88d6701a11f32e2e69994582524e0d7097b --- M configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py M configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py b/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py index e7a9e82..60d93eb 100644 --- a/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py +++ b/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py @@ -306,7 +306,7 @@ print("Performance statistics:") roi_begin_ticks = simulator.get_tick_stopwatch()[0][1] -roi_end_ticks = simulator.get_tick_stopwatch()[0][1] +roi_end_ticks = simulator.get_tick_stopwatch()[1][1] print("roi simulated ticks: " + str(roi_end_ticks - roi_begin_ticks)) diff --git a/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py b/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py index 531ce94..c491c9b 100644 --- a/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py +++ b/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py @@ -288,6 +288,7 @@ print("Done bootling Linux") print("Resetting stats at the start of ROI!") m5.stats.reset() + processor.switch() yield False # E.g., continue the simulation. print("Dump stats at the end of the ROI!") m5.stats.dump() @@ -319,7 +320,11 @@ print() print("Performance statistics:") -print("Simulated time in ROI: " + ((str(simulator.get_roi_ticks()[0])))) +roi_begin_ticks = simulator.get_tick_stopwatch()[0][1] +roi_end_ticks = simulator.get_tick_stopwatch()[1][1] + +print("roi simulated ticks: " + str(roi_end_ticks - roi_begin_ticks)) + print( "Ran a total of", simulator.get_current_tick() / 1e12, "simulated seconds" ) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/69537?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: If0b6f88d6701a11f32e2e69994582524e0d7097b Gerrit-Change-Number: 69537 Gerrit-PatchSet: 1 Gerrit-Owner: humza jahangir ikram <humzajahangirikram@gmail.com> Gerrit-MessageType: newchange