gem5-dev@gem5.org

The gem5 Developer List

View all threads

[XS] Change in gem5/gem5[develop]: arch-sparc: Rewrite unused array in tgt_stat64 for mac

BB
Bobby Bruce (Gerrit)
Tue, Apr 4, 2023 12:06 AM

Bobby Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/68838?usp=email )

Change subject: arch-sparc: Rewrite unused array in tgt_stat64 for mac
......................................................................

arch-sparc: Rewrite unused array in tgt_stat64 for mac

On Mac (tested on Mac Mini M2 Pro) the src/arch/sparc/linux/linux.hh was
uncompilable due to int64_t __unused[3] not working with the Mac
GLIB's __unused definition. This was therefore rewritten.

Change-Id: I8094a54ccf8dedb8e63ef05770e48eef7012262c
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/68838
Maintainer: Bobby Bruce bbruce@ucdavis.edu
Tested-by: kokoro noreply+kokoro@google.com
Reviewed-by: Melissa Jost mkjost@ucdavis.edu

M src/arch/sparc/linux/linux.hh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
Melissa Jost: Looks good to me, approved
kokoro: Regressions pass
Bobby Bruce: Looks good to me, approved

diff --git a/src/arch/sparc/linux/linux.hh b/src/arch/sparc/linux/linux.hh
index a5d88ab..5913ddb 100644
--- a/src/arch/sparc/linux/linux.hh
+++ b/src/arch/sparc/linux/linux.hh
@@ -89,7 +89,7 @@
uint64_t st_mtime_nsec;
uint64_t st_ctimeX;
uint64_t st_ctime_nsec;

  •    int64_t __unused[3];
    
  •    int64_t __unused4[3];
    };
    
    // SPARC receives weird subsignals for several of its signals. If you
    

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/68838?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I8094a54ccf8dedb8e63ef05770e48eef7012262c
Gerrit-Change-Number: 68838
Gerrit-PatchSet: 5
Gerrit-Owner: Bobby Bruce bbruce@ucdavis.edu
Gerrit-Reviewer: Bobby Bruce bbruce@ucdavis.edu
Gerrit-Reviewer: Gabe Black gabe.black@gmail.com
Gerrit-Reviewer: Melissa Jost mkjost@ucdavis.edu
Gerrit-Reviewer: kokoro noreply+kokoro@google.com
Gerrit-MessageType: merged

Bobby Bruce has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/68838?usp=email ) Change subject: arch-sparc: Rewrite unused array in tgt_stat64 for mac ...................................................................... arch-sparc: Rewrite unused array in tgt_stat64 for mac On Mac (tested on Mac Mini M2 Pro) the src/arch/sparc/linux/linux.hh was uncompilable due to `int64_t __unused[3]` not working with the Mac GLIB's `__unused` definition. This was therefore rewritten. Change-Id: I8094a54ccf8dedb8e63ef05770e48eef7012262c Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/68838 Maintainer: Bobby Bruce <bbruce@ucdavis.edu> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Melissa Jost <mkjost@ucdavis.edu> --- M src/arch/sparc/linux/linux.hh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Melissa Jost: Looks good to me, approved kokoro: Regressions pass Bobby Bruce: Looks good to me, approved diff --git a/src/arch/sparc/linux/linux.hh b/src/arch/sparc/linux/linux.hh index a5d88ab..5913ddb 100644 --- a/src/arch/sparc/linux/linux.hh +++ b/src/arch/sparc/linux/linux.hh @@ -89,7 +89,7 @@ uint64_t st_mtime_nsec; uint64_t st_ctimeX; uint64_t st_ctime_nsec; - int64_t __unused[3]; + int64_t __unused4[3]; }; // SPARC receives weird subsignals for several of its signals. If you -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/68838?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I8094a54ccf8dedb8e63ef05770e48eef7012262c Gerrit-Change-Number: 68838 Gerrit-PatchSet: 5 Gerrit-Owner: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: Gabe Black <gabe.black@gmail.com> Gerrit-Reviewer: Melissa Jost <mkjost@ucdavis.edu> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com> Gerrit-MessageType: merged