Bobby Bruce has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/71499?usp=email ) Change subject: util: '-eq' -> '-ge' for if in vm_manager.sh ...................................................................... util: '-eq' -> '-ge' for if in vm_manager.sh A small nit-pick change that ensures that cases where the number of arguments being >1 does not result in the argument checking being skipped (NOTE: arguments after the first are never processed and are ignored). Change-Id: If7e9c16c2c3581ea95ed888586736618d1ae5f5f Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/71499 Reviewed-by: Jason Lowe-Power <power.jg@gmail.com> Maintainer: Jason Lowe-Power <power.jg@gmail.com> Reviewed-by: Daniel Carvalho <odanrc@yahoo.com.br> Tested-by: kokoro <noreply+kokoro@google.com> --- M util/github-runners-vagrant/vm_manager.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Carvalho: Looks good to me, approved kokoro: Regressions pass Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved diff --git a/util/github-runners-vagrant/vm_manager.sh b/util/github-runners-vagrant/vm_manager.sh index 1cae8d2..0e2f4b7 100755 --- a/util/github-runners-vagrant/vm_manager.sh +++ b/util/github-runners-vagrant/vm_manager.sh @@ -9,7 +9,7 @@ export VAGRANT_HOME=${SCRIPT_DIR} param="up" -if [[ $# -eq 1 ]]; then +if [[ $# -ge 1 ]]; then param=$1 if [[ "${param}" != "destroy" ]]; then echo "Only valid parameter is 'destroy', to destroy all VMs" -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/71499?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: If7e9c16c2c3581ea95ed888586736618d1ae5f5f Gerrit-Change-Number: 71499 Gerrit-PatchSet: 2 Gerrit-Owner: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: Daniel Carvalho <odanrc@yahoo.com.br> Gerrit-Reviewer: Gabe Black <gabe.black@gmail.com> Gerrit-Reviewer: Jason Lowe-Power <power.jg@gmail.com> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com> Gerrit-CC: kokoro <noreply+kokoro@google.com>