gem5-dev@gem5.org

The gem5 Developer List

View all threads

[XS] Change in gem5/gem5[develop]: dev-amdgpu: Remove unused psp_ring_retval integer

MJ
Melissa Jost (Gerrit)
Tue, May 2, 2023 4:46 PM

Melissa Jost has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/70217?usp=email )

Change subject: dev-amdgpu: Remove unused psp_ring_retval integer
......................................................................

dev-amdgpu: Remove unused psp_ring_retval integer

This change addresses the compiler failures that have been
causing any GCN3_X86 build to fail.
https://jenkins.gem5.org/job/compiler-checks/589/

Change-Id: Ifd8e2ef89549752ca4aedf0bc9fa47e831a822d3
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/70217
Reviewed-by: Matthew Poremba matthew.poremba@amd.com
Reviewed-by: Matt Sinclair mattdsinclair@gmail.com
Maintainer: Matthew Poremba matthew.poremba@amd.com
Tested-by: kokoro noreply+kokoro@google.com

M src/dev/amdgpu/amdgpu_nbio.hh
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
Matt Sinclair: Looks good to me, approved
Matthew Poremba: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass

diff --git a/src/dev/amdgpu/amdgpu_nbio.hh b/src/dev/amdgpu/amdgpu_nbio.hh
index 68d174e..d1e5391 100644
--- a/src/dev/amdgpu/amdgpu_nbio.hh
+++ b/src/dev/amdgpu/amdgpu_nbio.hh
@@ -109,7 +109,6 @@
Addr psp_ring_dev_addr = 0;
Addr psp_ring_listen_addr = 0;
int psp_ring_size = 0;

  • int psp_ring_retval = 0;
    int psp_ring_value = 0;
    };

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/70217?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-MessageType: merged
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ifd8e2ef89549752ca4aedf0bc9fa47e831a822d3
Gerrit-Change-Number: 70217
Gerrit-PatchSet: 2
Gerrit-Owner: Melissa Jost melissakjost@gmail.com
Gerrit-Reviewer: Matt Sinclair mattdsinclair@gmail.com
Gerrit-Reviewer: Matthew Poremba matthew.poremba@amd.com
Gerrit-Reviewer: Melissa Jost mkjost@ucdavis.edu
Gerrit-Reviewer: kokoro noreply+kokoro@google.com

Melissa Jost has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/70217?usp=email ) Change subject: dev-amdgpu: Remove unused psp_ring_retval integer ...................................................................... dev-amdgpu: Remove unused psp_ring_retval integer This change addresses the compiler failures that have been causing any GCN3_X86 build to fail. https://jenkins.gem5.org/job/compiler-checks/589/ Change-Id: Ifd8e2ef89549752ca4aedf0bc9fa47e831a822d3 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/70217 Reviewed-by: Matthew Poremba <matthew.poremba@amd.com> Reviewed-by: Matt Sinclair <mattdsinclair@gmail.com> Maintainer: Matthew Poremba <matthew.poremba@amd.com> Tested-by: kokoro <noreply+kokoro@google.com> --- M src/dev/amdgpu/amdgpu_nbio.hh 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Matt Sinclair: Looks good to me, approved Matthew Poremba: Looks good to me, approved; Looks good to me, approved kokoro: Regressions pass diff --git a/src/dev/amdgpu/amdgpu_nbio.hh b/src/dev/amdgpu/amdgpu_nbio.hh index 68d174e..d1e5391 100644 --- a/src/dev/amdgpu/amdgpu_nbio.hh +++ b/src/dev/amdgpu/amdgpu_nbio.hh @@ -109,7 +109,6 @@ Addr psp_ring_dev_addr = 0; Addr psp_ring_listen_addr = 0; int psp_ring_size = 0; - int psp_ring_retval = 0; int psp_ring_value = 0; }; -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/70217?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-MessageType: merged Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ifd8e2ef89549752ca4aedf0bc9fa47e831a822d3 Gerrit-Change-Number: 70217 Gerrit-PatchSet: 2 Gerrit-Owner: Melissa Jost <melissakjost@gmail.com> Gerrit-Reviewer: Matt Sinclair <mattdsinclair@gmail.com> Gerrit-Reviewer: Matthew Poremba <matthew.poremba@amd.com> Gerrit-Reviewer: Melissa Jost <mkjost@ucdavis.edu> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com>