gem5-dev@gem5.org

The gem5 Developer List

View all threads

[XS] Change in gem5/gem5[develop]: arch-riscv: Insert symbol table of bootloader into debug symbol table...

RC
Roger Chang (Gerrit)
Thu, Apr 13, 2023 12:10 AM

Roger Chang has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/69697?usp=email )

Change subject: arch-riscv: Insert symbol table of bootloader into debug
symbol table in bare metal workload
......................................................................

arch-riscv: Insert symbol table of bootloader into debug symbol table
in bare metal workload

Change-Id: Iea2ded4e72070b7b3b588000e1082180269e9e5e
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/69697
Tested-by: kokoro noreply+kokoro@google.com
Maintainer: Gabe Black gabeblack@google.com
Reviewed-by: Yu-hsin Wang yuhsingw@google.com

M src/arch/riscv/bare_metal/fs_workload.cc
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
Yu-hsin Wang: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass

diff --git a/src/arch/riscv/bare_metal/fs_workload.cc
b/src/arch/riscv/bare_metal/fs_workload.cc
index 4f7adb3..574c944 100644
--- a/src/arch/riscv/bare_metal/fs_workload.cc
+++ b/src/arch/riscv/bare_metal/fs_workload.cc
@@ -47,6 +47,8 @@
fatal_if(!bootloader, "Could not load bootloader file %s.",
p.bootloader);
_resetVect = bootloader->entryPoint();
bootloaderSymtab = bootloader->symtab();
+

  • loader::debugSymbolTable.insert(bootloaderSymtab);
    }

BareMetal::~BareMetal()

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/69697?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Iea2ded4e72070b7b3b588000e1082180269e9e5e
Gerrit-Change-Number: 69697
Gerrit-PatchSet: 3
Gerrit-Owner: Roger Chang rogerycchang@google.com
Gerrit-Reviewer: Gabe Black gabe.black@gmail.com
Gerrit-Reviewer: Gabe Black gabeblack@google.com
Gerrit-Reviewer: Roger Chang rogerycchang@google.com
Gerrit-Reviewer: Yu-hsin Wang yuhsingw@google.com
Gerrit-Reviewer: kokoro noreply+kokoro@google.com
Gerrit-MessageType: merged

Roger Chang has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/69697?usp=email ) Change subject: arch-riscv: Insert symbol table of bootloader into debug symbol table in bare metal workload ...................................................................... arch-riscv: Insert symbol table of bootloader into debug symbol table in bare metal workload Change-Id: Iea2ded4e72070b7b3b588000e1082180269e9e5e Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/69697 Tested-by: kokoro <noreply+kokoro@google.com> Maintainer: Gabe Black <gabeblack@google.com> Reviewed-by: Yu-hsin Wang <yuhsingw@google.com> --- M src/arch/riscv/bare_metal/fs_workload.cc 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Yu-hsin Wang: Looks good to me, approved Gabe Black: Looks good to me, approved kokoro: Regressions pass diff --git a/src/arch/riscv/bare_metal/fs_workload.cc b/src/arch/riscv/bare_metal/fs_workload.cc index 4f7adb3..574c944 100644 --- a/src/arch/riscv/bare_metal/fs_workload.cc +++ b/src/arch/riscv/bare_metal/fs_workload.cc @@ -47,6 +47,8 @@ fatal_if(!bootloader, "Could not load bootloader file %s.", p.bootloader); _resetVect = bootloader->entryPoint(); bootloaderSymtab = bootloader->symtab(); + + loader::debugSymbolTable.insert(bootloaderSymtab); } BareMetal::~BareMetal() -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/69697?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Iea2ded4e72070b7b3b588000e1082180269e9e5e Gerrit-Change-Number: 69697 Gerrit-PatchSet: 3 Gerrit-Owner: Roger Chang <rogerycchang@google.com> Gerrit-Reviewer: Gabe Black <gabe.black@gmail.com> Gerrit-Reviewer: Gabe Black <gabeblack@google.com> Gerrit-Reviewer: Roger Chang <rogerycchang@google.com> Gerrit-Reviewer: Yu-hsin Wang <yuhsingw@google.com> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com> Gerrit-MessageType: merged