gem5-dev@gem5.org

The gem5 Developer List

View all threads

[XS] Change in gem5/gem5[develop]: scons: Pass the CPATH environment variable through to SCons.

YW
Yu-hsin Wang (Gerrit)
Thu, Jul 6, 2023 2:27 AM

Yu-hsin Wang has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/72038?usp=email )

Change subject: scons: Pass the CPATH environment variable through to SCons.
......................................................................

scons: Pass the CPATH environment variable through to SCons.

For sandbox environment, the default include may be override by CPATH.
To make the SCons can work in this environment, we need to pass CPATH
into SCons.

Change-Id: I1015f20a553a2e18595c8d2a89b209ca665879fd
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/72038
Reviewed-by: Jason Lowe-Power power.jg@gmail.com
Tested-by: kokoro noreply+kokoro@google.com
Maintainer: Jason Lowe-Power power.jg@gmail.com

M site_scons/gem5_scons/defaults.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass

diff --git a/site_scons/gem5_scons/defaults.py
b/site_scons/gem5_scons/defaults.py
index f800b67..944f7e5 100644
--- a/site_scons/gem5_scons/defaults.py
+++ b/site_scons/gem5_scons/defaults.py
@@ -52,6 +52,7 @@
"CC",
"CXX",
"HOME",

  •        "CPATH",
            "LD_LIBRARY_PATH",
            "LIBRARY_PATH",
            "PATH",
    

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/72038?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I1015f20a553a2e18595c8d2a89b209ca665879fd
Gerrit-Change-Number: 72038
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-hsin Wang yuhsingw@google.com
Gerrit-Reviewer: Gabe Black gabe.black@gmail.com
Gerrit-Reviewer: Jason Lowe-Power power.jg@gmail.com
Gerrit-Reviewer: Yu-hsin Wang yuhsingw@google.com
Gerrit-Reviewer: kokoro noreply+kokoro@google.com
Gerrit-CC: Earl Ou shunhsingou@google.com
Gerrit-CC: Roger Chang rogerycchang@google.com
Gerrit-CC: kokoro noreply+kokoro@google.com

Yu-hsin Wang has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/72038?usp=email ) Change subject: scons: Pass the CPATH environment variable through to SCons. ...................................................................... scons: Pass the CPATH environment variable through to SCons. For sandbox environment, the default include may be override by CPATH. To make the SCons can work in this environment, we need to pass CPATH into SCons. Change-Id: I1015f20a553a2e18595c8d2a89b209ca665879fd Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/72038 Reviewed-by: Jason Lowe-Power <power.jg@gmail.com> Tested-by: kokoro <noreply+kokoro@google.com> Maintainer: Jason Lowe-Power <power.jg@gmail.com> --- M site_scons/gem5_scons/defaults.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved kokoro: Regressions pass diff --git a/site_scons/gem5_scons/defaults.py b/site_scons/gem5_scons/defaults.py index f800b67..944f7e5 100644 --- a/site_scons/gem5_scons/defaults.py +++ b/site_scons/gem5_scons/defaults.py @@ -52,6 +52,7 @@ "CC", "CXX", "HOME", + "CPATH", "LD_LIBRARY_PATH", "LIBRARY_PATH", "PATH", -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/72038?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I1015f20a553a2e18595c8d2a89b209ca665879fd Gerrit-Change-Number: 72038 Gerrit-PatchSet: 2 Gerrit-Owner: Yu-hsin Wang <yuhsingw@google.com> Gerrit-Reviewer: Gabe Black <gabe.black@gmail.com> Gerrit-Reviewer: Jason Lowe-Power <power.jg@gmail.com> Gerrit-Reviewer: Yu-hsin Wang <yuhsingw@google.com> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com> Gerrit-CC: Earl Ou <shunhsingou@google.com> Gerrit-CC: Roger Chang <rogerycchang@google.com> Gerrit-CC: kokoro <noreply+kokoro@google.com>