gem5-dev@gem5.org

The gem5 Developer List

View all threads

[XS] Change in gem5/gem5[develop]: cpu: Fix assignment to lastActivate in SimpleThread::suspend()

RC
Richard Cooper (Gerrit)
Wed, Apr 12, 2023 7:41 AM

Richard Cooper has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/69689?usp=email )

Change subject: cpu: Fix assignment to lastActivate in
SimpleThread::suspend()
......................................................................

cpu: Fix assignment to lastActivate in SimpleThread::suspend()

Remove the assignment to lastActivate in SimpleThread::suspend();
This appears to be a copy-and-paste error that escaped notice.

Change-Id: I44461b38b0f09d309d821531409b460216e07131

M src/cpu/simple_thread.cc
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/cpu/simple_thread.cc b/src/cpu/simple_thread.cc
index c28359a..655d989 100644
--- a/src/cpu/simple_thread.cc
+++ b/src/cpu/simple_thread.cc
@@ -1,5 +1,5 @@
/*

    • Copyright (c) 2018, 2020 ARM Limited
    • Copyright (c) 2018, 2020, 2023 Arm Limited
    • All rights reserved
    • The license below extends only to copyright in the software and shall
      @@ -146,7 +146,6 @@
      if (status() == ThreadContext::Suspended)
      return;
  • lastActivate = curTick();
    lastSuspend = curTick();
    _status = ThreadContext::Suspended;
    baseCpu->suspendContext(_threadId);

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/69689?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I44461b38b0f09d309d821531409b460216e07131
Gerrit-Change-Number: 69689
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Cooper richard.cooper@arm.com
Gerrit-MessageType: newchange

Richard Cooper has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/69689?usp=email ) Change subject: cpu: Fix assignment to lastActivate in SimpleThread::suspend() ...................................................................... cpu: Fix assignment to lastActivate in SimpleThread::suspend() Remove the assignment to lastActivate in SimpleThread::suspend(); This appears to be a copy-and-paste error that escaped notice. Change-Id: I44461b38b0f09d309d821531409b460216e07131 --- M src/cpu/simple_thread.cc 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/cpu/simple_thread.cc b/src/cpu/simple_thread.cc index c28359a..655d989 100644 --- a/src/cpu/simple_thread.cc +++ b/src/cpu/simple_thread.cc @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020 ARM Limited + * Copyright (c) 2018, 2020, 2023 Arm Limited * All rights reserved * * The license below extends only to copyright in the software and shall @@ -146,7 +146,6 @@ if (status() == ThreadContext::Suspended) return; - lastActivate = curTick(); lastSuspend = curTick(); _status = ThreadContext::Suspended; baseCpu->suspendContext(_threadId); -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/69689?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I44461b38b0f09d309d821531409b460216e07131 Gerrit-Change-Number: 69689 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Cooper <richard.cooper@arm.com> Gerrit-MessageType: newchange