Alex Richardson has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/68758?usp=email ) Change subject: scons: default to not duplicating sources in the build directory ...................................................................... scons: default to not duplicating sources in the build directory We now default to --no-duplicate-sources, but keep --duplicate-sources to opt-out of this new build behaviour in case it introduces regressions. Change-Id: I2f01ceaef7b6b9bff80f4402081f007110f7e6f3 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/68758 Maintainer: Bobby Bruce <bbruce@ucdavis.edu> Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu> Tested-by: kokoro <noreply+kokoro@google.com> --- M SConstruct 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Bobby Bruce: Looks good to me, approved; Looks good to me, approved kokoro: Regressions pass diff --git a/SConstruct b/SConstruct index e09f0d5..9b25b33 100755 --- a/SConstruct +++ b/SConstruct @@ -145,7 +145,13 @@ help='Enable support for the gprof profiler') AddOption('--pprof', action='store_true', help='Enable support for the pprof profiler') -AddOption('--no-duplicate-sources', action='store_false', default=True, +# Default to --no-duplicate-sources, but keep --duplicate-sources to opt-out +# of this new build behaviour in case it introduces regressions. We could use +# action=argparse.BooleanOptionalAction here once Python 3.9 is required. +AddOption('--duplicate-sources', action='store_true', default=False, + dest='duplicate_sources', + help='Create symlinks to sources in the build directory') +AddOption('--no-duplicate-sources', action='store_false', dest='duplicate_sources', help='Do not create symlinks to sources in the build directory') -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/68758?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I2f01ceaef7b6b9bff80f4402081f007110f7e6f3 Gerrit-Change-Number: 68758 Gerrit-PatchSet: 6 Gerrit-Owner: Alex Richardson <alexrichardson@google.com> Gerrit-Reviewer: Alex Richardson <alexrichardson@google.com> Gerrit-Reviewer: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: Gabe Black <gabe.black@gmail.com> Gerrit-Reviewer: Gabe Black <gabeblack@google.com> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com>