gem5-dev@gem5.org

The gem5 Developer List

View all threads

[XS] Change in gem5/gem5[develop]: base: Output link to common errors page

MJ
Melissa Jost (Gerrit)
Fri, May 26, 2023 4:42 AM

Melissa Jost has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/70978?usp=email )

Change subject: base: Output link to common errors page
......................................................................

base: Output link to common errors page

This change adds a link to the common errors page that outputs
whenever a fatal signal is raised, showing when the program
aborts or segfaults.

Change-Id: I88420a594423570af670b460cfce7c03c4208120
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/70978
Reviewed-by: Jason Lowe-Power power.jg@gmail.com
Maintainer: Daniel Carvalho odanrc@yahoo.com.br
Tested-by: kokoro noreply+kokoro@google.com
Reviewed-by: Daniel Carvalho odanrc@yahoo.com.br

M src/sim/init_signals.cc
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
Daniel Carvalho: Looks good to me, but someone else must approve; Looks
good to me, approved
kokoro: Regressions pass
Jason Lowe-Power: Looks good to me, approved

diff --git a/src/sim/init_signals.cc b/src/sim/init_signals.cc
index b6db621..b9aa6f6 100644
--- a/src/sim/init_signals.cc
+++ b/src/sim/init_signals.cc
@@ -103,6 +103,8 @@
// The signal handler should have been reset and unmasked (it was
// registered with SA_RESETHAND | SA_NODEFER), just raise the
// signal again to invoke the default handler.

  • STATIC_ERR("For more info on how to address this issue, please visit "
  •    "https://www.gem5.org/documentation/general_docs/common-errors/  
    

\n\n");
pthread_kill(pthread_self(), signo);

  // Something is really wrong if the process is alive at this

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/70978?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I88420a594423570af670b460cfce7c03c4208120
Gerrit-Change-Number: 70978
Gerrit-PatchSet: 2
Gerrit-Owner: Melissa Jost melissakjost@gmail.com
Gerrit-Reviewer: Bobby Bruce bbruce@ucdavis.edu
Gerrit-Reviewer: Daniel Carvalho odanrc@yahoo.com.br
Gerrit-Reviewer: Jason Lowe-Power power.jg@gmail.com
Gerrit-Reviewer: Melissa Jost melissakjost@gmail.com
Gerrit-Reviewer: kokoro noreply+kokoro@google.com

Melissa Jost has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/70978?usp=email ) Change subject: base: Output link to common errors page ...................................................................... base: Output link to common errors page This change adds a link to the common errors page that outputs whenever a fatal signal is raised, showing when the program aborts or segfaults. Change-Id: I88420a594423570af670b460cfce7c03c4208120 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/70978 Reviewed-by: Jason Lowe-Power <power.jg@gmail.com> Maintainer: Daniel Carvalho <odanrc@yahoo.com.br> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Daniel Carvalho <odanrc@yahoo.com.br> --- M src/sim/init_signals.cc 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Daniel Carvalho: Looks good to me, but someone else must approve; Looks good to me, approved kokoro: Regressions pass Jason Lowe-Power: Looks good to me, approved diff --git a/src/sim/init_signals.cc b/src/sim/init_signals.cc index b6db621..b9aa6f6 100644 --- a/src/sim/init_signals.cc +++ b/src/sim/init_signals.cc @@ -103,6 +103,8 @@ // The signal handler should have been reset and unmasked (it was // registered with SA_RESETHAND | SA_NODEFER), just raise the // signal again to invoke the default handler. + STATIC_ERR("For more info on how to address this issue, please visit " + "https://www.gem5.org/documentation/general_docs/common-errors/ \n\n"); pthread_kill(pthread_self(), signo); // Something is really wrong if the process is alive at this -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/70978?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I88420a594423570af670b460cfce7c03c4208120 Gerrit-Change-Number: 70978 Gerrit-PatchSet: 2 Gerrit-Owner: Melissa Jost <melissakjost@gmail.com> Gerrit-Reviewer: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: Daniel Carvalho <odanrc@yahoo.com.br> Gerrit-Reviewer: Jason Lowe-Power <power.jg@gmail.com> Gerrit-Reviewer: Melissa Jost <melissakjost@gmail.com> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com>