gem5-dev@gem5.org

The gem5 Developer List

View all threads

[XS] Change in gem5/gem5[develop]: arch-riscv: Fix WFI for O3 CPU

BB
Bobby Bruce (Gerrit)
Tue, May 16, 2023 12:29 AM

Bobby Bruce has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/70657?usp=email )

Change subject: arch-riscv: Fix WFI for O3 CPU
......................................................................

arch-riscv: Fix WFI for O3 CPU

This commit:
https://gem5-review.googlesource.com/c/public/gem5/+/61511
introduced a bug where the O3 CPU hangs. This is because WFI must be
tagged as IsNonSpeculative and IsSerializeAfter to function
correctly with O3 CPUs.

Change-Id: I8b6cb049710d05f37f89a9ce22acc604112bc445
Issue-on: https://gem5.atlassian.net/browse/GEM5-1323

M src/arch/riscv/isa/decoder.isa
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/arch/riscv/isa/decoder.isa b/src/arch/riscv/isa/decoder.isa
index f22efb0..e58ceb9 100644
--- a/src/arch/riscv/isa/decoder.isa
+++ b/src/arch/riscv/isa/decoder.isa
@@ -2278,7 +2278,7 @@
&& xc->readMiscReg(MISCREG_NMIP) == 0) {
tc->quiesce();
}

  •                    }}, No_OpClass);
    
  •                    }}, IsNonSpeculative, IsSerializeAfter,   
    

No_OpClass);
}
0x9: sfence_vma({{
STATUS status = xc->readMiscReg(MISCREG_STATUS);

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/70657?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I8b6cb049710d05f37f89a9ce22acc604112bc445
Gerrit-Change-Number: 70657
Gerrit-PatchSet: 1
Gerrit-Owner: Bobby Bruce bbruce@ucdavis.edu

Bobby Bruce has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/70657?usp=email ) Change subject: arch-riscv: Fix WFI for O3 CPU ...................................................................... arch-riscv: Fix WFI for O3 CPU This commit: https://gem5-review.googlesource.com/c/public/gem5/+/61511 introduced a bug where the O3 CPU hangs. This is because WFI must be tagged as `IsNonSpeculative` and `IsSerializeAfter` to function correctly with O3 CPUs. Change-Id: I8b6cb049710d05f37f89a9ce22acc604112bc445 Issue-on: https://gem5.atlassian.net/browse/GEM5-1323 --- M src/arch/riscv/isa/decoder.isa 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/arch/riscv/isa/decoder.isa b/src/arch/riscv/isa/decoder.isa index f22efb0..e58ceb9 100644 --- a/src/arch/riscv/isa/decoder.isa +++ b/src/arch/riscv/isa/decoder.isa @@ -2278,7 +2278,7 @@ && xc->readMiscReg(MISCREG_NMIP) == 0) { tc->quiesce(); } - }}, No_OpClass); + }}, IsNonSpeculative, IsSerializeAfter, No_OpClass); } 0x9: sfence_vma({{ STATUS status = xc->readMiscReg(MISCREG_STATUS); -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/70657?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I8b6cb049710d05f37f89a9ce22acc604112bc445 Gerrit-Change-Number: 70657 Gerrit-PatchSet: 1 Gerrit-Owner: Bobby Bruce <bbruce@ucdavis.edu>