gem5-dev@gem5.org

The gem5 Developer List

View all threads

[XS] Change in gem5/gem5[develop]: base: Add missing headers in extensible.hh

WC
Wei-Han Chen (Gerrit)
Sat, Apr 8, 2023 1:21 AM

Wei-Han Chen has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/69480?usp=email )

Change subject: base: Add missing headers in extensible.hh
......................................................................

base: Add missing headers in extensible.hh

Add missing headers <cassert> and <type_traits> in extensible.hh

Change-Id: I01e49c62619383ea4f7da668ceaefe4a41418cd8
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/69480
Tested-by: kokoro noreply+kokoro@google.com
Reviewed-by: Daniel Carvalho odanrc@yahoo.com.br
Maintainer: Daniel Carvalho odanrc@yahoo.com.br

M src/base/extensible.hh
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
kokoro: Regressions pass
Daniel Carvalho: Looks good to me, approved; Looks good to me, approved

diff --git a/src/base/extensible.hh b/src/base/extensible.hh
index e80103c..5acf49f 100644
--- a/src/base/extensible.hh
+++ b/src/base/extensible.hh
@@ -36,8 +36,10 @@
#ifndef BASE_EXTENSIBLE_HH
#define BASE_EXTENSIBLE_HH

+#include <cassert>
#include <list>
#include <memory>
+#include <type_traits>
#include <utility>

namespace gem5

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/69480?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I01e49c62619383ea4f7da668ceaefe4a41418cd8
Gerrit-Change-Number: 69480
Gerrit-PatchSet: 3
Gerrit-Owner: Wei-Han Chen weihanchen@google.com
Gerrit-Reviewer: Bobby Bruce bbruce@ucdavis.edu
Gerrit-Reviewer: Daniel Carvalho odanrc@yahoo.com.br
Gerrit-Reviewer: Wei-Han Chen weihanchen@google.com
Gerrit-Reviewer: Yan Lee yanlee@google.com
Gerrit-Reviewer: Yu-hsin Wang yuhsingw@google.com
Gerrit-Reviewer: kokoro noreply+kokoro@google.com
Gerrit-MessageType: merged

Wei-Han Chen has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/69480?usp=email ) Change subject: base: Add missing headers in extensible.hh ...................................................................... base: Add missing headers in extensible.hh Add missing headers <cassert> and <type_traits> in extensible.hh Change-Id: I01e49c62619383ea4f7da668ceaefe4a41418cd8 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/69480 Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Daniel Carvalho <odanrc@yahoo.com.br> Maintainer: Daniel Carvalho <odanrc@yahoo.com.br> --- M src/base/extensible.hh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: kokoro: Regressions pass Daniel Carvalho: Looks good to me, approved; Looks good to me, approved diff --git a/src/base/extensible.hh b/src/base/extensible.hh index e80103c..5acf49f 100644 --- a/src/base/extensible.hh +++ b/src/base/extensible.hh @@ -36,8 +36,10 @@ #ifndef __BASE_EXTENSIBLE_HH__ #define __BASE_EXTENSIBLE_HH__ +#include <cassert> #include <list> #include <memory> +#include <type_traits> #include <utility> namespace gem5 -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/69480?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I01e49c62619383ea4f7da668ceaefe4a41418cd8 Gerrit-Change-Number: 69480 Gerrit-PatchSet: 3 Gerrit-Owner: Wei-Han Chen <weihanchen@google.com> Gerrit-Reviewer: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: Daniel Carvalho <odanrc@yahoo.com.br> Gerrit-Reviewer: Wei-Han Chen <weihanchen@google.com> Gerrit-Reviewer: Yan Lee <yanlee@google.com> Gerrit-Reviewer: Yu-hsin Wang <yuhsingw@google.com> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com> Gerrit-MessageType: merged