gem5-dev@gem5.org

The gem5 Developer List

View all threads

[XS] Change in gem5/gem5[develop]: util: '-eq' -> '-ge' for if in vm_manager.sh

BB
Bobby Bruce (Gerrit)
Mon, Jun 12, 2023 7:30 PM

Bobby Bruce has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/71499?usp=email )

Change subject: util: '-eq' -> '-ge' for if in vm_manager.sh
......................................................................

util: '-eq' -> '-ge' for if in vm_manager.sh

A small nit-pick change that ensures that cases where the number of
arguments being >1 does not result in the argument checking being
skipped (NOTE: arguments after the first are never processed and are
ignored).

Change-Id: If7e9c16c2c3581ea95ed888586736618d1ae5f5f

M util/github-runners-vagrant/vm_manager.sh
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/github-runners-vagrant/vm_manager.sh
b/util/github-runners-vagrant/vm_manager.sh
index 1cae8d2..0e2f4b7 100755
--- a/util/github-runners-vagrant/vm_manager.sh
+++ b/util/github-runners-vagrant/vm_manager.sh
@@ -9,7 +9,7 @@
export VAGRANT_HOME=${SCRIPT_DIR}

param="up"
-if [[ $# -eq 1 ]]; then
+if [[ $# -ge 1 ]]; then
param=$1
if [[ "${param}" != "destroy" ]]; then
echo "Only valid parameter is 'destroy', to destroy all VMs"

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/71499?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: If7e9c16c2c3581ea95ed888586736618d1ae5f5f
Gerrit-Change-Number: 71499
Gerrit-PatchSet: 1
Gerrit-Owner: Bobby Bruce bbruce@ucdavis.edu

Bobby Bruce has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/71499?usp=email ) Change subject: util: '-eq' -> '-ge' for if in vm_manager.sh ...................................................................... util: '-eq' -> '-ge' for if in vm_manager.sh A small nit-pick change that ensures that cases where the number of arguments being >1 does not result in the argument checking being skipped (NOTE: arguments after the first are never processed and are ignored). Change-Id: If7e9c16c2c3581ea95ed888586736618d1ae5f5f --- M util/github-runners-vagrant/vm_manager.sh 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/github-runners-vagrant/vm_manager.sh b/util/github-runners-vagrant/vm_manager.sh index 1cae8d2..0e2f4b7 100755 --- a/util/github-runners-vagrant/vm_manager.sh +++ b/util/github-runners-vagrant/vm_manager.sh @@ -9,7 +9,7 @@ export VAGRANT_HOME=${SCRIPT_DIR} param="up" -if [[ $# -eq 1 ]]; then +if [[ $# -ge 1 ]]; then param=$1 if [[ "${param}" != "destroy" ]]; then echo "Only valid parameter is 'destroy', to destroy all VMs" -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/71499?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: If7e9c16c2c3581ea95ed888586736618d1ae5f5f Gerrit-Change-Number: 71499 Gerrit-PatchSet: 1 Gerrit-Owner: Bobby Bruce <bbruce@ucdavis.edu>