Bobby Bruce has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/72178?usp=email ) Change subject: scons: Remove -Werror for the gem5 v23.0 release ...................................................................... scons: Remove -Werror for the gem5 v23.0 release While gem5 compiles on all our supported compilers, removing the -Werror flag on the stable branch ensures that, as new compilers are released with stricter warnings, gem5 remains compilable. Change-Id: Ie32a5c526a17cc584bce3b71d27b8f052caf612b Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/72178 Maintainer: Bobby Bruce <bbruce@ucdavis.edu> Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu> Tested-by: kokoro <noreply+kokoro@google.com> --- M SConstruct 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Bobby Bruce: Looks good to me, approved; Looks good to me, approved kokoro: Regressions pass diff --git a/SConstruct b/SConstruct index 9b25b33..4fe2f64 100755 --- a/SConstruct +++ b/SConstruct @@ -447,12 +447,6 @@ conf.CheckLinkFlag( '-Wl,--thread-count=%d' % GetOption('num_jobs')) - # Treat warnings as errors but white list some warnings that we - # want to allow (e.g., deprecation warnings). - env.Append(CCFLAGS=['-Werror', - '-Wno-error=deprecated-declarations', - '-Wno-error=deprecated', - ]) else: error('\n'.join(( -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/72178?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: public/gem5 Gerrit-Branch: release-staging-v23-0 Gerrit-Change-Id: Ie32a5c526a17cc584bce3b71d27b8f052caf612b Gerrit-Change-Number: 72178 Gerrit-PatchSet: 2 Gerrit-Owner: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: Gabe Black <gabe.black@gmail.com> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com> Gerrit-CC: kokoro <noreply+kokoro@google.com>