gem5-dev@gem5.org

The gem5 Developer List

View all threads

[XS] Change in gem5/gem5[develop]: cpu-kvm: Implement IPC and CPI base stats for KVM CPU

BB
Bobby Bruce (Gerrit)
Mon, May 8, 2023 7:09 PM

Bobby Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/69104?usp=email )

(

3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
)Change subject: cpu-kvm: Implement IPC and CPI base stats for KVM CPU
......................................................................

cpu-kvm: Implement IPC and CPI base stats for KVM CPU

Replaced committedInsts stats of KVM CPU with commitStats.numInsts
of BaseCPU. This results in IPC and CPI printing in stats.txt for
KVM simulation.

Change-Id: Ia7713f88f15e3cabd4c96a8c2921515340bc71e2
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/69104
Reviewed-by: Andreas Sandberg andreas.sandberg@arm.com
Maintainer: Andreas Sandberg andreas.sandberg@arm.com
Tested-by: kokoro noreply+kokoro@google.com

M src/cpu/kvm/base.cc
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
Andreas Sandberg: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass

diff --git a/src/cpu/kvm/base.cc b/src/cpu/kvm/base.cc
index b76bddc..5857f69 100644
--- a/src/cpu/kvm/base.cc
+++ b/src/cpu/kvm/base.cc
@@ -779,6 +779,9 @@
/* Update statistics */
baseStats.numCycles += simCyclesExecuted;;
stats.committedInsts += instsExecuted;

  •    // update both old and new stats
    
  •    commitStats[thread->threadId()]->numInsts += instsExecuted;
    
  •    baseStats.numInsts += instsExecuted;
        ctrInsts += instsExecuted;
    
        DPRINTF(KvmRun,
    

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/69104?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ia7713f88f15e3cabd4c96a8c2921515340bc71e2
Gerrit-Change-Number: 69104
Gerrit-PatchSet: 11
Gerrit-Owner: Melissa Jost melissakjost@gmail.com
Gerrit-Reviewer: Andreas Sandberg andreas.sandberg@arm.com
Gerrit-Reviewer: Bobby Bruce bbruce@ucdavis.edu
Gerrit-Reviewer: kokoro noreply+kokoro@google.com

Bobby Bruce has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/69104?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: cpu-kvm: Implement IPC and CPI base stats for KVM CPU ...................................................................... cpu-kvm: Implement IPC and CPI base stats for KVM CPU Replaced committedInsts stats of KVM CPU with commitStats.numInsts of BaseCPU. This results in IPC and CPI printing in stats.txt for KVM simulation. Change-Id: Ia7713f88f15e3cabd4c96a8c2921515340bc71e2 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/69104 Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com> Maintainer: Andreas Sandberg <andreas.sandberg@arm.com> Tested-by: kokoro <noreply+kokoro@google.com> --- M src/cpu/kvm/base.cc 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Andreas Sandberg: Looks good to me, approved; Looks good to me, approved kokoro: Regressions pass diff --git a/src/cpu/kvm/base.cc b/src/cpu/kvm/base.cc index b76bddc..5857f69 100644 --- a/src/cpu/kvm/base.cc +++ b/src/cpu/kvm/base.cc @@ -779,6 +779,9 @@ /* Update statistics */ baseStats.numCycles += simCyclesExecuted;; stats.committedInsts += instsExecuted; + // update both old and new stats + commitStats[thread->threadId()]->numInsts += instsExecuted; + baseStats.numInsts += instsExecuted; ctrInsts += instsExecuted; DPRINTF(KvmRun, -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/69104?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ia7713f88f15e3cabd4c96a8c2921515340bc71e2 Gerrit-Change-Number: 69104 Gerrit-PatchSet: 11 Gerrit-Owner: Melissa Jost <melissakjost@gmail.com> Gerrit-Reviewer: Andreas Sandberg <andreas.sandberg@arm.com> Gerrit-Reviewer: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com>