Matt Sinclair has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/69258?usp=email ) ( 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: tests: add GPU Ruby Random tester with WB L2 caches ...................................................................... tests: add GPU Ruby Random tester with WB L2 caches The current GPU Ruby Random tester tests only test for WT L2 caches, meaning that some transitions (specific to WB caches) are never tested. To help ensure better coverage, this commit adds a separate test that tests WB GPU L2 caches to the per-checkin and nightly regressions. Change-Id: I539ece3b825b9a38630027d947dc11ebef588752 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/69258 Tested-by: kokoro <noreply+kokoro@google.com> Maintainer: Bobby Bruce <bbruce@ucdavis.edu> Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu> --- A tests/gem5/gpu/test_gpu_ruby_random_wbL2.py 1 file changed, 84 insertions(+), 0 deletions(-) Approvals: Bobby Bruce: Looks good to me, approved; Looks good to me, approved kokoro: Regressions pass diff --git a/tests/gem5/gpu/test_gpu_ruby_random_wbL2.py b/tests/gem5/gpu/test_gpu_ruby_random_wbL2.py new file mode 100644 index 0000000..9af4e65 --- /dev/null +++ b/tests/gem5/gpu/test_gpu_ruby_random_wbL2.py @@ -0,0 +1,84 @@ +# Copyright (c) 2023 The Board of Regents of the University of Wisconsin +# All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions are +# met: redistributions of source code must retain the above copyright +# notice, this list of conditions and the following disclaimer; +# redistributions in binary form must reproduce the above copyright +# notice, this list of conditions and the following disclaimer in the +# documentation and/or other materials provided with the distribution; +# neither the name of the copyright holders nor the names of its +# contributors may be used to endorse or promote products derived from +# this software without specific prior written permission. +# +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +from testlib import * + +""" +This file contains random tests for the Ruby GPU protocols with a WB L2 cache. +""" + +# This test will first run the GPU protocol random tester -- it should take +# about 30 seconds to run and provides good coverage for the coherence +# protocol. +# +# Input choices (some are default and thus implicit): +# - use small cache size to encourage races +# - use small system size to encourage races since more requests per CU (and +# faster sim) +# - use small address range to encourage more races +# - use small episode length to encourage more races +# - 50K tests runs in ~30 seconds with reasonably good coverage +# - num-dmas = 0 because VIPER doesn't support partial cache line writes, which +# DMAs need +gem5_verify_config( + name="ruby-gpu-random-test-wbL2-perCheckin", + fixtures=(), + verifiers=(), + config=joinpath( + config.base_dir, "configs", "example", "ruby_gpu_random_test.py" + ), + config_args=["--WB_L2", "--test-length", "50000", "--num-dmas", "0"], + valid_isas=(constants.vega_x86_tag,), + valid_hosts=constants.supported_hosts, + length=constants.long_tag, +) + + +# This test will run the GPU protocol random tester in nightly -- it should +# take about 30 minutes to run and provides good coverage for the coherence +# protocol. +# +# Input choices (some are default and thus implicit): +# - use small cache size to encourage races +# - use small system size to encourage races since more requests per CU (and +# faster sim) +# - use small address range to encourage more races +# - use small episode length to encourage more races +# - 5M tests runs in ~30 minutes with reasonably good coverage +# - num-dmas = 0 because VIPER doesn't support partial cache line writes, +# which DMAs need +gem5_verify_config( + name="ruby-gpu-random-test-wbL2-nightly", + fixtures=(), + verifiers=(), + config=joinpath( + config.base_dir, "configs", "example", "ruby_gpu_random_test.py" + ), + config_args=["--WB_L2", "--test-length", "5000000", "--num-dmas", "0"], + valid_isas=(constants.vega_x86_tag,), + valid_hosts=constants.supported_hosts, + length=constants.long_tag, +) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/69258?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I539ece3b825b9a38630027d947dc11ebef588752 Gerrit-Change-Number: 69258 Gerrit-PatchSet: 6 Gerrit-Owner: Matt Sinclair <mattdsinclair.wisc@gmail.com> Gerrit-Reviewer: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: Bradford Beckmann <bradford.beckmann@gmail.com> Gerrit-Reviewer: Matt Sinclair <mattdsinclair.wisc@gmail.com> Gerrit-Reviewer: Matthew Poremba <matthew.poremba@amd.com> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com> Gerrit-CC: Jason Lowe-Power <jason@lowepower.com> Gerrit-MessageType: merged