gem5-dev@gem5.org

The gem5 Developer List

View all threads

[XS] Change in gem5/gem5[develop]: configs: Update riscv/fs_linux.py script

RC
Roger Chang (Gerrit)
Sun, May 21, 2023 11:56 PM

Roger Chang has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/70177?usp=email )

Change subject: configs: Update riscv/fs_linux.py script
......................................................................

configs: Update riscv/fs_linux.py script

This change fixes a couple of small issues with
the configs/example/riscv/fs_linux.py script to ensure
that it works with the latest version of gem5.

Change-Id: I9753ca4c8dd0b87d05681b167cf51e3c097e9152
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/70177
Reviewed-by: Jason Lowe-Power power.jg@gmail.com
Maintainer: Jason Lowe-Power power.jg@gmail.com
Reviewed-by: Alex Richardson alexrichardson@google.com
Tested-by: kokoro noreply+kokoro@google.com
Reviewed-by: Roger Chang rogerycchang@google.com

M configs/example/riscv/fs_linux.py
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
Jason Lowe-Power: Looks good to me, but someone else must approve; Looks
good to me, approved
Alex Richardson: Looks good to me, but someone else must approve
Roger Chang: Looks good to me, approved
kokoro: Regressions pass

diff --git a/configs/example/riscv/fs_linux.py
b/configs/example/riscv/fs_linux.py
index aec126a..949c7e2 100644
--- a/configs/example/riscv/fs_linux.py
+++ b/configs/example/riscv/fs_linux.py
@@ -187,6 +187,7 @@

RTCCLK (Set to 100MHz for faster simulation)

system.platform.rtc = RiscvRTC(frequency=Frequency("100MHz"))
system.platform.clint.int_pin = system.platform.rtc.int_pin
+system.platform.pci_host.pio = system.iobus.mem_side_ports

VirtIOMMIO

if args.disk_image:
@@ -236,8 +237,6 @@
clock=args.cpu_clock, voltage_domain=system.cpu_voltage_domain
)

-system.workload.object_file = args.kernel

NOTE: Not yet tested

if args.script is not None:
system.readfile = args.script

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/70177?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I9753ca4c8dd0b87d05681b167cf51e3c097e9152
Gerrit-Change-Number: 70177
Gerrit-PatchSet: 2
Gerrit-Owner: Ayaz Akram yazakram@ucdavis.edu
Gerrit-Reviewer: Alex Richardson alexrichardson@google.com
Gerrit-Reviewer: Jason Lowe-Power jason@lowepower.com
Gerrit-Reviewer: Jason Lowe-Power power.jg@gmail.com
Gerrit-Reviewer: Roger Chang rogerycchang@google.com
Gerrit-Reviewer: kokoro noreply+kokoro@google.com

Roger Chang has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/70177?usp=email ) Change subject: configs: Update riscv/fs_linux.py script ...................................................................... configs: Update riscv/fs_linux.py script This change fixes a couple of small issues with the configs/example/riscv/fs_linux.py script to ensure that it works with the latest version of gem5. Change-Id: I9753ca4c8dd0b87d05681b167cf51e3c097e9152 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/70177 Reviewed-by: Jason Lowe-Power <power.jg@gmail.com> Maintainer: Jason Lowe-Power <power.jg@gmail.com> Reviewed-by: Alex Richardson <alexrichardson@google.com> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Roger Chang <rogerycchang@google.com> --- M configs/example/riscv/fs_linux.py 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jason Lowe-Power: Looks good to me, but someone else must approve; Looks good to me, approved Alex Richardson: Looks good to me, but someone else must approve Roger Chang: Looks good to me, approved kokoro: Regressions pass diff --git a/configs/example/riscv/fs_linux.py b/configs/example/riscv/fs_linux.py index aec126a..949c7e2 100644 --- a/configs/example/riscv/fs_linux.py +++ b/configs/example/riscv/fs_linux.py @@ -187,6 +187,7 @@ # RTCCLK (Set to 100MHz for faster simulation) system.platform.rtc = RiscvRTC(frequency=Frequency("100MHz")) system.platform.clint.int_pin = system.platform.rtc.int_pin +system.platform.pci_host.pio = system.iobus.mem_side_ports # VirtIOMMIO if args.disk_image: @@ -236,8 +237,6 @@ clock=args.cpu_clock, voltage_domain=system.cpu_voltage_domain ) -system.workload.object_file = args.kernel - # NOTE: Not yet tested if args.script is not None: system.readfile = args.script -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/70177?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I9753ca4c8dd0b87d05681b167cf51e3c097e9152 Gerrit-Change-Number: 70177 Gerrit-PatchSet: 2 Gerrit-Owner: Ayaz Akram <yazakram@ucdavis.edu> Gerrit-Reviewer: Alex Richardson <alexrichardson@google.com> Gerrit-Reviewer: Jason Lowe-Power <jason@lowepower.com> Gerrit-Reviewer: Jason Lowe-Power <power.jg@gmail.com> Gerrit-Reviewer: Roger Chang <rogerycchang@google.com> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com>