gem5-dev@gem5.org

The gem5 Developer List

View all threads

[S] Change in gem5/gem5[develop]: util: Update GitHub Runners Vagrant to overcommit memory

BB
Bobby Bruce (Gerrit)
Mon, Jun 12, 2023 7:30 PM

Bobby Bruce has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/71498?usp=email )

Change subject: util: Update GitHub Runners Vagrant to overcommit memory
......................................................................

util: Update GitHub Runners Vagrant to overcommit memory

SE mode tests were failing in some cases where the VM did not have
enough memory to satisfy the constraints of the simulated system. This
change ensures the VM allows overcommitting of memory.

Change-Id: I1800288e16146bdae612a401c2ff282d8664892d

M util/github-runners-vagrant/Vagrantfile-builder
M util/github-runners-vagrant/Vagrantfile-runner
2 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/util/github-runners-vagrant/Vagrantfile-builder
b/util/github-runners-vagrant/Vagrantfile-builder
index 242e094..cd36e78 100644
--- a/util/github-runners-vagrant/Vagrantfile-builder
+++ b/util/github-runners-vagrant/Vagrantfile-builder
@@ -22,6 +22,11 @@
config.vm.provision :shell, privileged: false,
path: "provision_nonroot.sh"
# The provision_root.sh adds the vagrant user to the docker group, so we
need to reload the VM.
config.vm.provision :reload

  • config.vm.provision :shell, run: 'always', inline: <<-SHELL
  • When running gem5 in SE mode we must overcommit memory.

  • This is run on every startup of the VM.

  • /sbin/sysctl vm.overcommit_memory=1
  • SHELL
    config.vm.provision :shell, privileged: false, run: 'always', inline:
    <<-SHELL
    if [ -d ~/actions-runner ]; then
    # This will be run everytime the VM is run (once created).
    diff --git a/util/github-runners-vagrant/Vagrantfile-runner
    b/util/github-runners-vagrant/Vagrantfile-runner
    index ab601cd..854e5f5 100644
    --- a/util/github-runners-vagrant/Vagrantfile-runner
    +++ b/util/github-runners-vagrant/Vagrantfile-runner
    @@ -22,6 +22,11 @@
    config.vm.provision :shell, privileged: false,
    path: "provision_nonroot.sh"

    The provision_root.sh adds the vagrant user to the docker group, so we

need to reload the VM.
config.vm.provision :reload

  • config.vm.provision :shell, run: 'always', inline: <<-SHELL
  • When running gem5 in SE mode we must overcommit memory.

  • This is run on every startup of the VM.

  • /sbin/sysctl vm.overcommit_memory=1
  • SHELL
    config.vm.provision :shell, privileged: false, run: 'always', inline:
    <<-SHELL
    if [ -d ~/actions-runner ]; then
    # This will be run everytime the VM is run (once created).

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/71498?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I1800288e16146bdae612a401c2ff282d8664892d
Gerrit-Change-Number: 71498
Gerrit-PatchSet: 1
Gerrit-Owner: Bobby Bruce bbruce@ucdavis.edu

Bobby Bruce has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/71498?usp=email ) Change subject: util: Update GitHub Runners Vagrant to overcommit memory ...................................................................... util: Update GitHub Runners Vagrant to overcommit memory SE mode tests were failing in some cases where the VM did not have enough memory to satisfy the constraints of the simulated system. This change ensures the VM allows overcommitting of memory. Change-Id: I1800288e16146bdae612a401c2ff282d8664892d --- M util/github-runners-vagrant/Vagrantfile-builder M util/github-runners-vagrant/Vagrantfile-runner 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/util/github-runners-vagrant/Vagrantfile-builder b/util/github-runners-vagrant/Vagrantfile-builder index 242e094..cd36e78 100644 --- a/util/github-runners-vagrant/Vagrantfile-builder +++ b/util/github-runners-vagrant/Vagrantfile-builder @@ -22,6 +22,11 @@ config.vm.provision :shell, privileged: false, path: "provision_nonroot.sh" # The provision_root.sh adds the vagrant user to the docker group, so we need to reload the VM. config.vm.provision :reload + config.vm.provision :shell, run: 'always', inline: <<-SHELL + # When running gem5 in SE mode we must overcommit memory. + # This is run on every startup of the VM. + /sbin/sysctl vm.overcommit_memory=1 + SHELL config.vm.provision :shell, privileged: false, run: 'always', inline: <<-SHELL if [ -d ~/actions-runner ]; then # This will be run everytime the VM is run (once created). diff --git a/util/github-runners-vagrant/Vagrantfile-runner b/util/github-runners-vagrant/Vagrantfile-runner index ab601cd..854e5f5 100644 --- a/util/github-runners-vagrant/Vagrantfile-runner +++ b/util/github-runners-vagrant/Vagrantfile-runner @@ -22,6 +22,11 @@ config.vm.provision :shell, privileged: false, path: "provision_nonroot.sh" # The provision_root.sh adds the vagrant user to the docker group, so we need to reload the VM. config.vm.provision :reload + config.vm.provision :shell, run: 'always', inline: <<-SHELL + # When running gem5 in SE mode we must overcommit memory. + # This is run on every startup of the VM. + /sbin/sysctl vm.overcommit_memory=1 + SHELL config.vm.provision :shell, privileged: false, run: 'always', inline: <<-SHELL if [ -d ~/actions-runner ]; then # This will be run everytime the VM is run (once created). -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/71498?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I1800288e16146bdae612a401c2ff282d8664892d Gerrit-Change-Number: 71498 Gerrit-PatchSet: 1 Gerrit-Owner: Bobby Bruce <bbruce@ucdavis.edu>