gem5-dev@gem5.org

The gem5 Developer List

View all threads

[XS] Change in gem5/gem5[develop]: cpu: Add CpuCluster method to allow querying the number of CPUs.

RC
Richard Cooper (Gerrit)
Thu, Apr 13, 2023 9:09 PM

Richard Cooper has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/69678?usp=email )

Change subject: cpu: Add CpuCluster method to allow querying the number of
CPUs.
......................................................................

cpu: Add CpuCluster method to allow querying the number of CPUs.

Add a __len__ method to CpuCluster to allow clients to query the
number of CPUs.

Change-Id: I6fe680423ed6fc301faaf75b8685b080a4774fef
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/69678
Tested-by: kokoro noreply+kokoro@google.com
Reviewed-by: Jason Lowe-Power power.jg@gmail.com
Maintainer: Jason Lowe-Power power.jg@gmail.com

M src/cpu/CpuCluster.py
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass

diff --git a/src/cpu/CpuCluster.py b/src/cpu/CpuCluster.py
index 31fdc49..42a7112 100644
--- a/src/cpu/CpuCluster.py
+++ b/src/cpu/CpuCluster.py
@@ -1,4 +1,4 @@
-# Copyright (c) 2022 Arm Limited
+# Copyright (c) 2022-2023 Arm Limited

All rights reserved.

The license below extends only to copyright in the software and shall

@@ -51,6 +51,9 @@
def iter(self):
return iter(self.cpus)

  • def len(self):
  •    return len(self.cpus)
    
  • def generate_cpus(self, cpu_type: "BaseCPU", num_cpus: int):
        """
        Instantiates the cpus within the cluster provided
    

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/69678?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I6fe680423ed6fc301faaf75b8685b080a4774fef
Gerrit-Change-Number: 69678
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Cooper richard.cooper@arm.com
Gerrit-Reviewer: Bobby Bruce bbruce@ucdavis.edu
Gerrit-Reviewer: Daniel Carvalho odanrc@yahoo.com.br
Gerrit-Reviewer: Gabe Black gabe.black@gmail.com
Gerrit-Reviewer: Jason Lowe-Power jason@lowepower.com
Gerrit-Reviewer: Jason Lowe-Power power.jg@gmail.com
Gerrit-Reviewer: Richard Cooper richard.cooper@arm.com
Gerrit-Reviewer: kokoro noreply+kokoro@google.com
Gerrit-CC: Giacomo Travaglini giacomo.travaglini@arm.com
Gerrit-MessageType: merged

Richard Cooper has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/69678?usp=email ) Change subject: cpu: Add CpuCluster method to allow querying the number of CPUs. ...................................................................... cpu: Add CpuCluster method to allow querying the number of CPUs. Add a `__len__` method to `CpuCluster` to allow clients to query the number of CPUs. Change-Id: I6fe680423ed6fc301faaf75b8685b080a4774fef Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/69678 Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Jason Lowe-Power <power.jg@gmail.com> Maintainer: Jason Lowe-Power <power.jg@gmail.com> --- M src/cpu/CpuCluster.py 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved kokoro: Regressions pass diff --git a/src/cpu/CpuCluster.py b/src/cpu/CpuCluster.py index 31fdc49..42a7112 100644 --- a/src/cpu/CpuCluster.py +++ b/src/cpu/CpuCluster.py @@ -1,4 +1,4 @@ -# Copyright (c) 2022 Arm Limited +# Copyright (c) 2022-2023 Arm Limited # All rights reserved. # # The license below extends only to copyright in the software and shall @@ -51,6 +51,9 @@ def __iter__(self): return iter(self.cpus) + def __len__(self): + return len(self.cpus) + def generate_cpus(self, cpu_type: "BaseCPU", num_cpus: int): """ Instantiates the cpus within the cluster provided -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/69678?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I6fe680423ed6fc301faaf75b8685b080a4774fef Gerrit-Change-Number: 69678 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Cooper <richard.cooper@arm.com> Gerrit-Reviewer: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: Daniel Carvalho <odanrc@yahoo.com.br> Gerrit-Reviewer: Gabe Black <gabe.black@gmail.com> Gerrit-Reviewer: Jason Lowe-Power <jason@lowepower.com> Gerrit-Reviewer: Jason Lowe-Power <power.jg@gmail.com> Gerrit-Reviewer: Richard Cooper <richard.cooper@arm.com> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com> Gerrit-CC: Giacomo Travaglini <giacomo.travaglini@arm.com> Gerrit-MessageType: merged