Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/69157?usp=email ) Change subject: base: Flip the default for ListenSocket::accept(bool nodelay). ...................................................................... base: Flip the default for ListenSocket::accept(bool nodelay). This option was almost always overridden from false to true anyway, except in one place (in the ethertap device) which was likely just by accident. This will give external users a chance to remove the option without changing behavior, so that the option can be removed entirely in a later change. Change-Id: I77add40b8131b91997b2aecbfff6c7de0ee9ead9 --- M src/base/socket.hh 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/base/socket.hh b/src/base/socket.hh index f3b2760..af4a651 100644 --- a/src/base/socket.hh +++ b/src/base/socket.hh @@ -104,7 +104,7 @@ ListenSocket(); virtual ~ListenSocket(); - virtual int accept(bool nodelay = false); + virtual int accept(bool nodelay = true); virtual bool listen(int port, bool reuse = true); -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/69157?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I77add40b8131b91997b2aecbfff6c7de0ee9ead9 Gerrit-Change-Number: 69157 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black <gabe.black@gmail.com> Gerrit-CC: Gabe Black <gabeblack@google.com> Gerrit-MessageType: newchange