VISHNU RAMADAS has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/69300?usp=email ) Change subject: dev-amdgpu: Remove write queue size check in DRAMCtrl drain ...................................................................... dev-amdgpu: Remove write queue size check in DRAMCtrl drain Currently the DRAMCtrl drain has checks to see if read, write, and response queues are empty before draining. The write queue commits the value to memory when it is placed in the queue and models the timing later when the queue is drained. Since the writes are already functionally done, the write queue size does not need to be empty before drain. This commit removes the write queue check inside MemCtrl::drain() Change-Id: I8e5f949d4ce8b89c6a17c1165677d6421dac935a --- M src/mem/mem_ctrl.cc 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mem/mem_ctrl.cc b/src/mem/mem_ctrl.cc index 543d637..599f765 100644 --- a/src/mem/mem_ctrl.cc +++ b/src/mem/mem_ctrl.cc @@ -1411,8 +1411,7 @@ { // if there is anything in any of our internal queues, keep track // of that as well - if (!(!totalWriteQueueSize && !totalReadQueueSize && respQueue.empty() && - allIntfDrained())) { + if (!(!totalReadQueueSize && respQueue.empty())) { DPRINTF(Drain, "Memory controller not drained, write: %d, read: %d," " resp: %d\n", totalWriteQueueSize, totalReadQueueSize, -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/69300?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I8e5f949d4ce8b89c6a17c1165677d6421dac935a Gerrit-Change-Number: 69300 Gerrit-PatchSet: 1 Gerrit-Owner: VISHNU RAMADAS <vramadas@wisc.edu> Gerrit-MessageType: newchange