gem5-dev@gem5.org

The gem5 Developer List

View all threads

[XS] Change in gem5/gem5[develop]: arch-arm: Extend SCTLR to be 64-bit wide

GT
Giacomo Travaglini (Gerrit)
Wed, May 17, 2023 8:11 AM

Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/70566?usp=email )

(

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
)Change subject: arch-arm: Extend SCTLR to be 64-bit wide
......................................................................

arch-arm: Extend SCTLR to be 64-bit wide

In AArch64 SCTLR_EL1/_EL2/_EL3 is 64-bit wide

Change-Id: I80931f9dd1a57f3132229b84d32a8ab08eee3371
Signed-off-by: Giacomo Travaglini giacomo.travaglini@arm.com
Reviewed-by: Richard Cooper richard.cooper@arm.com
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/70566
Tested-by: kokoro noreply+kokoro@google.com
Maintainer: Jason Lowe-Power power.jg@gmail.com

M src/arch/arm/regs/misc_types.hh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
kokoro: Regressions pass
Richard Cooper: Looks good to me, approved
Jason Lowe-Power: Looks good to me, approved

diff --git a/src/arch/arm/regs/misc_types.hh
b/src/arch/arm/regs/misc_types.hh
index e6f7e40..c139f1a 100644
--- a/src/arch/arm/regs/misc_types.hh
+++ b/src/arch/arm/regs/misc_types.hh
@@ -371,7 +371,7 @@
Bitfield<0> ns;
EndBitUnion(SCR)

  • BitUnion32(SCTLR)
  • BitUnion64(SCTLR)
    Bitfield<31>  enia;    // ARMv8.3 PAuth
    Bitfield<30>  enib;    // ARMv8.3 PAuth
    Bitfield<30>  te;      // Thumb Exception Enable (AArch32 only)

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/70566?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I80931f9dd1a57f3132229b84d32a8ab08eee3371
Gerrit-Change-Number: 70566
Gerrit-PatchSet: 3
Gerrit-Owner: Giacomo Travaglini giacomo.travaglini@arm.com
Gerrit-Reviewer: Andreas Sandberg andreas.sandberg@arm.com
Gerrit-Reviewer: Giacomo Travaglini giacomo.travaglini@arm.com
Gerrit-Reviewer: Jason Lowe-Power power.jg@gmail.com
Gerrit-Reviewer: Richard Cooper richard.cooper@arm.com
Gerrit-Reviewer: kokoro noreply+kokoro@google.com

Giacomo Travaglini has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/70566?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: arch-arm: Extend SCTLR to be 64-bit wide ...................................................................... arch-arm: Extend SCTLR to be 64-bit wide In AArch64 SCTLR_EL1/_EL2/_EL3 is 64-bit wide Change-Id: I80931f9dd1a57f3132229b84d32a8ab08eee3371 Signed-off-by: Giacomo Travaglini <giacomo.travaglini@arm.com> Reviewed-by: Richard Cooper <richard.cooper@arm.com> Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/70566 Tested-by: kokoro <noreply+kokoro@google.com> Maintainer: Jason Lowe-Power <power.jg@gmail.com> --- M src/arch/arm/regs/misc_types.hh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: kokoro: Regressions pass Richard Cooper: Looks good to me, approved Jason Lowe-Power: Looks good to me, approved diff --git a/src/arch/arm/regs/misc_types.hh b/src/arch/arm/regs/misc_types.hh index e6f7e40..c139f1a 100644 --- a/src/arch/arm/regs/misc_types.hh +++ b/src/arch/arm/regs/misc_types.hh @@ -371,7 +371,7 @@ Bitfield<0> ns; EndBitUnion(SCR) - BitUnion32(SCTLR) + BitUnion64(SCTLR) Bitfield<31> enia; // ARMv8.3 PAuth Bitfield<30> enib; // ARMv8.3 PAuth Bitfield<30> te; // Thumb Exception Enable (AArch32 only) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/70566?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I80931f9dd1a57f3132229b84d32a8ab08eee3371 Gerrit-Change-Number: 70566 Gerrit-PatchSet: 3 Gerrit-Owner: Giacomo Travaglini <giacomo.travaglini@arm.com> Gerrit-Reviewer: Andreas Sandberg <andreas.sandberg@arm.com> Gerrit-Reviewer: Giacomo Travaglini <giacomo.travaglini@arm.com> Gerrit-Reviewer: Jason Lowe-Power <power.jg@gmail.com> Gerrit-Reviewer: Richard Cooper <richard.cooper@arm.com> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com>