Giacomo Travaglini has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/69077?usp=email ) Change subject: base: Remove unnecessary DEBUG guard ...................................................................... base: Remove unnecessary DEBUG guard There is no performance improvement on guarding a cprint before a panic. We should just print as many info as possible anytime we encounter a failure Change-Id: I3ee9fb2c3b8a8f23bdf6173bb2a010020f2b2572 Signed-off-by: Giacomo Travaglini <giacomo.travaglini@arm.com> Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/69077 Reviewed-by: Jason Lowe-Power <power.jg@gmail.com> Maintainer: Jason Lowe-Power <power.jg@gmail.com> Reviewed-by: Daniel Carvalho <odanrc@yahoo.com.br> Tested-by: kokoro <noreply+kokoro@google.com> --- M src/base/stats/info.cc 1 file changed, 3 insertions(+), 5 deletions(-) Approvals: Daniel Carvalho: Looks good to me, approved Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved kokoro: Regressions pass diff --git a/src/base/stats/info.cc b/src/base/stats/info.cc index 06e7ec9..8779cf0 100644 --- a/src/base/stats/info.cc +++ b/src/base/stats/info.cc @@ -172,13 +172,11 @@ Info::baseCheck() const { if (!(flags & statistics::init)) { -#ifdef DEBUG - cprintf("this is stat number %d\n", id); -#endif - panic("Not all stats have been initialized.\n" + panic("this is stat number %d\n" + "Not all stats have been initialized.\n" "You may need to add <ParentClass>::regStats() to a" " new SimObject's regStats() function. Name: %s", - name); + id, name); return false; } -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/69077?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I3ee9fb2c3b8a8f23bdf6173bb2a010020f2b2572 Gerrit-Change-Number: 69077 Gerrit-PatchSet: 2 Gerrit-Owner: Giacomo Travaglini <giacomo.travaglini@arm.com> Gerrit-Reviewer: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: Daniel Carvalho <odanrc@yahoo.com.br> Gerrit-Reviewer: Giacomo Travaglini <giacomo.travaglini@arm.com> Gerrit-Reviewer: Jason Lowe-Power <power.jg@gmail.com> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com> Gerrit-MessageType: merged