Bobby Bruce has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/71038?usp=email ) Change subject: stdlib: Fix incorrect path and checks for DRAMsim3 ...................................................................... stdlib: Fix incorrect path and checks for DRAMsim3 There are three bugs fixed in this patch: 1. The `dram_3_dir` was missing the "dramsim3" directory. 2. Missing `not` when checking if configs is a directory. 3. Missing `not` when checking if input file is a file. Change-Id: I185f4832c1c2f1ecc4e138c148ad7969ef9b6fd4 --- M src/python/gem5/components/memory/dramsim_3.py 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/python/gem5/components/memory/dramsim_3.py b/src/python/gem5/components/memory/dramsim_3.py index e5c1877..f154ba3 100644 --- a/src/python/gem5/components/memory/dramsim_3.py +++ b/src/python/gem5/components/memory/dramsim_3.py @@ -32,6 +32,7 @@ os.pardir, os.pardir, "ext", + "dramsim3", "DRAMsim3", ) @@ -47,11 +48,11 @@ "Please navigate to `ext` and run:\n" "git clone git@github.com:umd-memsys/DRAMsim3.git" ) - elif os.path.isdir(dramsim_3_mem_configs): + elif not os.path.isdir(dramsim_3_mem_configs): raise Exception( "The `ext/DRAMsim3/configs` directory cannot be found." ) - elif os.path.isfile(input_file): + elif not os.path.isfile(input_file): raise Exception( "The configuration file '" + input_file + "' cannot be found." ) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/71038?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I185f4832c1c2f1ecc4e138c148ad7969ef9b6fd4 Gerrit-Change-Number: 71038 Gerrit-PatchSet: 1 Gerrit-Owner: Bobby Bruce <bbruce@ucdavis.edu>