gem5-dev@gem5.org

The gem5 Developer List

View all threads

[XS] Change in gem5/gem5[develop]: dev: Warn when resp packet is error in dma port

WC
Wei-Han Chen (Gerrit)
Wed, Jun 21, 2023 8:40 AM

Wei-Han Chen has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/71778?usp=email )

Change subject: dev: Warn when resp packet is error in dma port
......................................................................

dev: Warn when resp packet is error in dma port

This CL adds a warning when the response packet is error.

Change-Id: I8e94dc2b85cd1753a4d6265cfda3cd5d6325f425

M src/dev/dma_device.cc
1 file changed, 1 insertion(+), 0 deletions(-)

diff --git a/src/dev/dma_device.cc b/src/dev/dma_device.cc
index 24e931e..70a74ee 100644
--- a/src/dev/dma_device.cc
+++ b/src/dev/dma_device.cc
@@ -68,6 +68,7 @@
{
// Should always see a response with a sender state.
assert(pkt->isResponse());

  • warn_if(pkt->isError(), "Response pkt error.");

    // Get the DMA sender state.
    auto state = dynamic_cast<DmaReqState>(pkt->senderState);

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/71778?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I8e94dc2b85cd1753a4d6265cfda3cd5d6325f425
Gerrit-Change-Number: 71778
Gerrit-PatchSet: 1
Gerrit-Owner: Wei-Han Chen weihanchen@google.com

Wei-Han Chen has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/71778?usp=email ) Change subject: dev: Warn when resp packet is error in dma port ...................................................................... dev: Warn when resp packet is error in dma port This CL adds a warning when the response packet is error. Change-Id: I8e94dc2b85cd1753a4d6265cfda3cd5d6325f425 --- M src/dev/dma_device.cc 1 file changed, 1 insertion(+), 0 deletions(-) diff --git a/src/dev/dma_device.cc b/src/dev/dma_device.cc index 24e931e..70a74ee 100644 --- a/src/dev/dma_device.cc +++ b/src/dev/dma_device.cc @@ -68,6 +68,7 @@ { // Should always see a response with a sender state. assert(pkt->isResponse()); + warn_if(pkt->isError(), "Response pkt error."); // Get the DMA sender state. auto *state = dynamic_cast<DmaReqState*>(pkt->senderState); -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/71778?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I8e94dc2b85cd1753a4d6265cfda3cd5d6325f425 Gerrit-Change-Number: 71778 Gerrit-PatchSet: 1 Gerrit-Owner: Wei-Han Chen <weihanchen@google.com>