Giacomo Travaglini has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/70559?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: arch-arm: Provide default mask for raz/rao helpers ...................................................................... arch-arm: Provide default mask for raz/rao helpers Rather than forcing raz registers to write something like: .raz(uint64_t(-1)) we provide a shorter version where if no bitmask is specified we assume the entire register is raz/rao. This won't be probably used by rao but I am striving for symmetry and providing a default won't probably hurt Change-Id: I309e345fc8336df3a74474f8f9202bf7e2095b41 Signed-off-by: Giacomo Travaglini <giacomo.travaglini@arm.com> Reviewed-by: Richard Cooper <richard.cooper@arm.com> Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/70559 Maintainer: Jason Lowe-Power <power.jg@gmail.com> Tested-by: kokoro <noreply+kokoro@google.com> --- M src/arch/arm/regs/misc.hh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jason Lowe-Power: Looks good to me, approved kokoro: Regressions pass Richard Cooper: Looks good to me, approved diff --git a/src/arch/arm/regs/misc.hh b/src/arch/arm/regs/misc.hh index 3a32623..abbd1c6 100644 --- a/src/arch/arm/regs/misc.hh +++ b/src/arch/arm/regs/misc.hh @@ -1249,13 +1249,13 @@ return *this; } chain - raz(uint64_t mask) const + raz(uint64_t mask = (uint64_t)-1) const { entry._raz = mask; return *this; } chain - rao(uint64_t mask) const + rao(uint64_t mask = (uint64_t)-1) const { entry._rao = mask; return *this; -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/70559?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I309e345fc8336df3a74474f8f9202bf7e2095b41 Gerrit-Change-Number: 70559 Gerrit-PatchSet: 3 Gerrit-Owner: Giacomo Travaglini <giacomo.travaglini@arm.com> Gerrit-Reviewer: Andreas Sandberg <andreas.sandberg@arm.com> Gerrit-Reviewer: Giacomo Travaglini <giacomo.travaglini@arm.com> Gerrit-Reviewer: Jason Lowe-Power <power.jg@gmail.com> Gerrit-Reviewer: Richard Cooper <richard.cooper@arm.com> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com>