gem5-dev@gem5.org

The gem5 Developer List

View all threads

[XS] Change in gem5/gem5[develop]: arch-arm: Extend SCTLR to be 64-bit wide

GT
Giacomo Travaglini (Gerrit)
Fri, May 12, 2023 8:45 AM

Attention is currently required from: Richard Cooper.

Hello Richard Cooper,

I'd like you to do a code review.
Please visit

 https://gem5-review.googlesource.com/c/public/gem5/+/70566?usp=email

to review the following change.

Change subject: arch-arm: Extend SCTLR to be 64-bit wide
......................................................................

arch-arm: Extend SCTLR to be 64-bit wide

In AArch64 SCTLR_EL1/_EL2/_EL3 is 64-bit wide

Change-Id: I80931f9dd1a57f3132229b84d32a8ab08eee3371
Signed-off-by: Giacomo Travaglini giacomo.travaglini@arm.com
Reviewed-by: Richard Cooper richard.cooper@arm.com

M src/arch/arm/regs/misc_types.hh
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/arch/arm/regs/misc_types.hh
b/src/arch/arm/regs/misc_types.hh
index e446ce5..7e7ff67 100644
--- a/src/arch/arm/regs/misc_types.hh
+++ b/src/arch/arm/regs/misc_types.hh
@@ -371,7 +371,7 @@
Bitfield<0> ns;
EndBitUnion(SCR)

  • BitUnion32(SCTLR)
  • BitUnion64(SCTLR)
    Bitfield<31>  enia;    // ARMv8.3 PAuth
    Bitfield<30>  enib;    // ARMv8.3 PAuth
    Bitfield<30>  te;      // Thumb Exception Enable (AArch32 only)

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/70566?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I80931f9dd1a57f3132229b84d32a8ab08eee3371
Gerrit-Change-Number: 70566
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini giacomo.travaglini@arm.com
Gerrit-Reviewer: Richard Cooper richard.cooper@arm.com
Gerrit-Attention: Richard Cooper richard.cooper@arm.com

Attention is currently required from: Richard Cooper. Hello Richard Cooper, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/70566?usp=email to review the following change. Change subject: arch-arm: Extend SCTLR to be 64-bit wide ...................................................................... arch-arm: Extend SCTLR to be 64-bit wide In AArch64 SCTLR_EL1/_EL2/_EL3 is 64-bit wide Change-Id: I80931f9dd1a57f3132229b84d32a8ab08eee3371 Signed-off-by: Giacomo Travaglini <giacomo.travaglini@arm.com> Reviewed-by: Richard Cooper <richard.cooper@arm.com> --- M src/arch/arm/regs/misc_types.hh 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/arch/arm/regs/misc_types.hh b/src/arch/arm/regs/misc_types.hh index e446ce5..7e7ff67 100644 --- a/src/arch/arm/regs/misc_types.hh +++ b/src/arch/arm/regs/misc_types.hh @@ -371,7 +371,7 @@ Bitfield<0> ns; EndBitUnion(SCR) - BitUnion32(SCTLR) + BitUnion64(SCTLR) Bitfield<31> enia; // ARMv8.3 PAuth Bitfield<30> enib; // ARMv8.3 PAuth Bitfield<30> te; // Thumb Exception Enable (AArch32 only) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/70566?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I80931f9dd1a57f3132229b84d32a8ab08eee3371 Gerrit-Change-Number: 70566 Gerrit-PatchSet: 1 Gerrit-Owner: Giacomo Travaglini <giacomo.travaglini@arm.com> Gerrit-Reviewer: Richard Cooper <richard.cooper@arm.com> Gerrit-Attention: Richard Cooper <richard.cooper@arm.com>