gem5-dev@gem5.org

The gem5 Developer List

View all threads

[XS] Change in gem5/gem5[develop]: scons: default to not duplicating sources in the build directory

AR
Alex Richardson (Gerrit)
Wed, Mar 8, 2023 10:02 AM

Alex Richardson has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/68758?usp=email )

Change subject: scons: default to not duplicating sources in the build
directory
......................................................................

scons: default to not duplicating sources in the build directory

We now default to --no-duplicate-sources, but keep --duplicate-sources to
opt-out of this new build behaviour in case it introduces regressions.

Change-Id: I2f01ceaef7b6b9bff80f4402081f007110f7e6f3

M SConstruct
1 file changed, 6 insertions(+), 0 deletions(-)

diff --git a/SConstruct b/SConstruct
index 7d6f406..e6e2157 100755
--- a/SConstruct
+++ b/SConstruct
@@ -145,6 +145,12 @@
help='Enable support for the gprof profiler')
AddOption('--pprof', action='store_true',
help='Enable support for the pprof profiler')
+# Default to --no-duplicate-sources, but keep --duplicate-sources to
opt-out
+# of this new build behaviour in case it introduces regressions. We could
use
+# action=argparse.BooleanOptionalAction here once Python 3.9 is required.
+AddOption('--duplicate-sources', action='store_true', default=False,

  •      dest='duplicate_sources',
    
  •      help='Create symlinks to sources in the build directory')
    
    AddOption('--no-duplicate-sources', action='store_false',
    dest='duplicate_sources',
    help='Do not create symlinks to sources in the build directory')

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/68758?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I2f01ceaef7b6b9bff80f4402081f007110f7e6f3
Gerrit-Change-Number: 68758
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Richardson alexrichardson@google.com
Gerrit-MessageType: newchange

Alex Richardson has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/68758?usp=email ) Change subject: scons: default to not duplicating sources in the build directory ...................................................................... scons: default to not duplicating sources in the build directory We now default to --no-duplicate-sources, but keep --duplicate-sources to opt-out of this new build behaviour in case it introduces regressions. Change-Id: I2f01ceaef7b6b9bff80f4402081f007110f7e6f3 --- M SConstruct 1 file changed, 6 insertions(+), 0 deletions(-) diff --git a/SConstruct b/SConstruct index 7d6f406..e6e2157 100755 --- a/SConstruct +++ b/SConstruct @@ -145,6 +145,12 @@ help='Enable support for the gprof profiler') AddOption('--pprof', action='store_true', help='Enable support for the pprof profiler') +# Default to --no-duplicate-sources, but keep --duplicate-sources to opt-out +# of this new build behaviour in case it introduces regressions. We could use +# action=argparse.BooleanOptionalAction here once Python 3.9 is required. +AddOption('--duplicate-sources', action='store_true', default=False, + dest='duplicate_sources', + help='Create symlinks to sources in the build directory') AddOption('--no-duplicate-sources', action='store_false', dest='duplicate_sources', help='Do not create symlinks to sources in the build directory') -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/68758?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I2f01ceaef7b6b9bff80f4402081f007110f7e6f3 Gerrit-Change-Number: 68758 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Richardson <alexrichardson@google.com> Gerrit-MessageType: newchange