Roger Chang has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/56952?usp=email )
Change subject: scons: Pass the DISPLAY environment variable through to
SCons.
......................................................................
scons: Pass the DISPLAY environment variable through to SCons.
This lets gui programs run correctly within SCons, specifically the
kconfig "guiconfig" helper utility.
M site_scons/gem5_scons/defaults.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Matthew Poremba: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/site_scons/gem5_scons/defaults.py
b/site_scons/gem5_scons/defaults.py
index 996cfd4..f800b67 100644
--- a/site_scons/gem5_scons/defaults.py
+++ b/site_scons/gem5_scons/defaults.py
@@ -67,6 +67,7 @@
"LINKFLAGS_EXTRA",
"LANG",
"LC_CTYPE",
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/56952?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Iec51df3db89ac7e7411e6c08fe8201afb69dc63e
Gerrit-Change-Number: 56952
Gerrit-PatchSet: 21
Gerrit-Owner: Gabe Black gabe.black@gmail.com
Gerrit-Reviewer: Andreas Sandberg andreas.sandberg@arm.com
Gerrit-Reviewer: Jason Lowe-Power power.jg@gmail.com
Gerrit-Reviewer: Matthew Poremba matthew.poremba@amd.com
Gerrit-Reviewer: Roger Chang rogerycchang@google.com
Gerrit-Reviewer: kokoro noreply+kokoro@google.com
Roger Chang has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/56952?usp=email )
Change subject: scons: Pass the DISPLAY environment variable through to
SCons.
......................................................................
scons: Pass the DISPLAY environment variable through to SCons.
This lets gui programs run correctly within SCons, specifically the
kconfig "guiconfig" helper utility.
Change-Id: Iec51df3db89ac7e7411e6c08fe8201afb69dc63e
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/56952
Reviewed-by: Matthew Poremba <matthew.poremba@amd.com>
Maintainer: Matthew Poremba <matthew.poremba@amd.com>
Tested-by: kokoro <noreply+kokoro@google.com>
---
M site_scons/gem5_scons/defaults.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Matthew Poremba: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/site_scons/gem5_scons/defaults.py
b/site_scons/gem5_scons/defaults.py
index 996cfd4..f800b67 100644
--- a/site_scons/gem5_scons/defaults.py
+++ b/site_scons/gem5_scons/defaults.py
@@ -67,6 +67,7 @@
"LINKFLAGS_EXTRA",
"LANG",
"LC_CTYPE",
+ "DISPLAY",
]
)
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/56952?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Iec51df3db89ac7e7411e6c08fe8201afb69dc63e
Gerrit-Change-Number: 56952
Gerrit-PatchSet: 21
Gerrit-Owner: Gabe Black <gabe.black@gmail.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandberg@arm.com>
Gerrit-Reviewer: Jason Lowe-Power <power.jg@gmail.com>
Gerrit-Reviewer: Matthew Poremba <matthew.poremba@amd.com>
Gerrit-Reviewer: Roger Chang <rogerycchang@google.com>
Gerrit-Reviewer: kokoro <noreply+kokoro@google.com>