gem5-dev@gem5.org

The gem5 Developer List

View all threads

[XS] Change in gem5/gem5[develop]: sim: Deprecate EventWrapper in favour of MemberEventWrapper

GB
Gabriel B. (Gerrit)
Mon, Mar 13, 2023 6:47 AM

Gabriel B. has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/67654?usp=email )

Change subject: sim: Deprecate EventWrapper in favour of MemberEventWrapper
......................................................................

sim: Deprecate EventWrapper in favour of MemberEventWrapper

Change-Id: I87363fb36cd998e7f0afeb25381e5b230a15b493
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/67654
Reviewed-by: Jason Lowe-Power power.jg@gmail.com
Maintainer: Jason Lowe-Power power.jg@gmail.com
Reviewed-by: Daniel Carvalho odanrc@yahoo.com.br
Tested-by: kokoro noreply+kokoro@google.com

M src/sim/eventq.hh
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
Daniel Carvalho: Looks good to me, approved
kokoro: Regressions pass
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved

diff --git a/src/sim/eventq.hh b/src/sim/eventq.hh
index b46a25b..ff9d4bf 100644
--- a/src/sim/eventq.hh
+++ b/src/sim/eventq.hh
@@ -1129,7 +1129,8 @@
};

template <class T, void (T::* F)()>
-using EventWrapper = MemberEventWrapper<F>;
+using EventWrapper [[deprecated("Use MemberEventWrapper instead")]]

  • = MemberEventWrapper<F>;

class EventFunctionWrapper : public Event
{

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/67654?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I87363fb36cd998e7f0afeb25381e5b230a15b493
Gerrit-Change-Number: 67654
Gerrit-PatchSet: 4
Gerrit-Owner: Gabriel B. gabriel.busnot@arteris.com
Gerrit-Reviewer: Daniel Carvalho odanrc@yahoo.com.br
Gerrit-Reviewer: Gabriel B. gabriel.busnot@arteris.com
Gerrit-Reviewer: Jason Lowe-Power jason@lowepower.com
Gerrit-Reviewer: Jason Lowe-Power power.jg@gmail.com
Gerrit-Reviewer: kokoro noreply+kokoro@google.com
Gerrit-MessageType: merged

Gabriel B. has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/67654?usp=email ) Change subject: sim: Deprecate EventWrapper in favour of MemberEventWrapper ...................................................................... sim: Deprecate EventWrapper in favour of MemberEventWrapper Change-Id: I87363fb36cd998e7f0afeb25381e5b230a15b493 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/67654 Reviewed-by: Jason Lowe-Power <power.jg@gmail.com> Maintainer: Jason Lowe-Power <power.jg@gmail.com> Reviewed-by: Daniel Carvalho <odanrc@yahoo.com.br> Tested-by: kokoro <noreply+kokoro@google.com> --- M src/sim/eventq.hh 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Carvalho: Looks good to me, approved kokoro: Regressions pass Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved diff --git a/src/sim/eventq.hh b/src/sim/eventq.hh index b46a25b..ff9d4bf 100644 --- a/src/sim/eventq.hh +++ b/src/sim/eventq.hh @@ -1129,7 +1129,8 @@ }; template <class T, void (T::* F)()> -using EventWrapper = MemberEventWrapper<F>; +using EventWrapper [[deprecated("Use MemberEventWrapper instead")]] + = MemberEventWrapper<F>; class EventFunctionWrapper : public Event { -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/67654?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I87363fb36cd998e7f0afeb25381e5b230a15b493 Gerrit-Change-Number: 67654 Gerrit-PatchSet: 4 Gerrit-Owner: Gabriel B. <gabriel.busnot@arteris.com> Gerrit-Reviewer: Daniel Carvalho <odanrc@yahoo.com.br> Gerrit-Reviewer: Gabriel B. <gabriel.busnot@arteris.com> Gerrit-Reviewer: Jason Lowe-Power <jason@lowepower.com> Gerrit-Reviewer: Jason Lowe-Power <power.jg@gmail.com> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com> Gerrit-MessageType: merged