gem5-dev@gem5.org

The gem5 Developer List

View all threads

[M] Change in gem5/gem5[develop]: tests: Disable the looppoint checkpoint tests

BB
Bobby Bruce (Gerrit)
Tue, Mar 28, 2023 6:46 AM

Bobby Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/69240?usp=email )

Change subject: tests: Disable the looppoint checkpoint tests
......................................................................

tests: Disable the looppoint checkpoint tests

The Looppoint checkpoint  feature is still under-development.
These tests are stalling indefinitely and causing the Weekly tests to
timeout. They are therefore disabled until looppoint functionality is
complete and this bug is resolved.

Change-Id: I2c16abdaec639120c0ba349d90f5cc2fe747f8e6
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/69240
Reviewed-by: Bobby Bruce bbruce@ucdavis.edu
Maintainer: Bobby Bruce bbruce@ucdavis.edu
Tested-by: kokoro noreply+kokoro@google.com

M tests/gem5/gem5_library_example_tests/test_gem5_library_examples.py
1 file changed, 55 insertions(+), 52 deletions(-)

Approvals:
kokoro: Regressions pass
Bobby Bruce: Looks good to me, approved; Looks good to me, approved

diff --git
a/tests/gem5/gem5_library_example_tests/test_gem5_library_examples.py
b/tests/gem5/gem5_library_example_tests/test_gem5_library_examples.py
index 7db46b0..e43d461 100644
--- a/tests/gem5/gem5_library_example_tests/test_gem5_library_examples.py
+++ b/tests/gem5/gem5_library_example_tests/test_gem5_library_examples.py
@@ -325,56 +325,59 @@
length=constants.very_long_tag,
)

-gem5_verify_config(

  • name="test-gem5-library-create-looppoint-checkpoints",
  • fixtures=(),
  • verifiers=(),
  • config=joinpath(
  •    config.base_dir,
    
  •    "configs",
    
  •    "example",
    
  •    "gem5_library",
    
  •    "looppoints",
    
  •    "create-looppoint-checkpoint.py",
    
  • ),
  • config_args=[
  •    "--checkpoint-path",
    
  •    joinpath(resource_path, "looppoint-checkpoint-save"),
    
  • ],
  • valid_isas=(constants.all_compiled_tag,),
  • valid_hosts=constants.supported_hosts,
  • length=constants.very_long_tag,
    -)
    +# The LoopPoint-Checkpointing feature is still under development, therefore
    +# these tests are temporarily disabled until this feature is complete.#

-for region in (

  • "1",
  • "2",
  • "3",
  • "5",
  • "6",
  • "7",
  • "8",
  • "9",
  • "10",
  • "11",
  • "12",
  • "13",
  • "14",
    -):
  • gem5_verify_config(

name=f"test-gem5-library-restore-looppoint-checkpoint-region-f{region}",

  •    fixtures=(),
    
  •    verifiers=(),
    
  •    config=joinpath(
    
  •        config.base_dir,
    
  •        "configs",
    
  •        "example",
    
  •        "gem5_library",
    
  •        "looppoints",
    
  •        "restore-looppoint-checkpoint.py",
    
  •    ),
    
  •    config_args=["--checkpoint-region", region],
    
  •    valid_isas=(constants.all_compiled_tag,),
    
  •    valid_hosts=constants.supported_hosts,
    
  •    length=constants.very_long_tag,
    
  • )
    +# gem5_verify_config(
    +#    name="test-gem5-library-create-looppoint-checkpoints",
    +#    fixtures=(),
    +#    verifiers=(),
    +#    config=joinpath(
    +#        config.base_dir,
    +#        "configs",
    +#        "example",
    +#        "gem5_library",
    +#        "looppoints",
    +#        "create-looppoint-checkpoint.py",
    +#    ),
    +#    config_args=[
    +#        "--checkpoint-path",
    +#        joinpath(resource_path, "looppoint-checkpoint-save"),
    +#    ],
    +#    valid_isas=(constants.all_compiled_tag,),
    +#    valid_hosts=constants.supported_hosts,
    +#    length=constants.very_long_tag,
    +# )

+# for region in (
+#    "1",
+#    "2",
+#    "3",
+#    "5",
+#    "6",
+#    "7",
+#    "8",
+#    "9",
+#    "10",
+#    "11",
+#    "12",
+#    "13",
+#    "14",
+# ):
+#    gem5_verify_config(
+#
name=f"test-gem5-library-restore-looppoint-checkpoint-region-f{region}",
+#        fixtures=(),
+#        verifiers=(),
+#        config=joinpath(
+#            config.base_dir,
+#            "configs",
+#            "example",
+#            "gem5_library",
+#            "looppoints",
+#            "restore-looppoint-checkpoint.py",
+#        ),
+#        config_args=["--checkpoint-region", region],
+#        valid_isas=(constants.all_compiled_tag,),
+#        valid_hosts=constants.supported_hosts,
+#        length=constants.very_long_tag,
+#    )

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/69240?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I2c16abdaec639120c0ba349d90f5cc2fe747f8e6
Gerrit-Change-Number: 69240
Gerrit-PatchSet: 3
Gerrit-Owner: Bobby Bruce bbruce@ucdavis.edu
Gerrit-Reviewer: Bobby Bruce bbruce@ucdavis.edu
Gerrit-Reviewer: Jason Lowe-Power power.jg@gmail.com
Gerrit-Reviewer: kokoro noreply+kokoro@google.com
Gerrit-MessageType: merged

Bobby Bruce has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/69240?usp=email ) Change subject: tests: Disable the looppoint checkpoint tests ...................................................................... tests: Disable the looppoint checkpoint tests The Looppoint checkpoint feature is still under-development. These tests are stalling indefinitely and causing the Weekly tests to timeout. They are therefore disabled until looppoint functionality is complete and this bug is resolved. Change-Id: I2c16abdaec639120c0ba349d90f5cc2fe747f8e6 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/69240 Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu> Maintainer: Bobby Bruce <bbruce@ucdavis.edu> Tested-by: kokoro <noreply+kokoro@google.com> --- M tests/gem5/gem5_library_example_tests/test_gem5_library_examples.py 1 file changed, 55 insertions(+), 52 deletions(-) Approvals: kokoro: Regressions pass Bobby Bruce: Looks good to me, approved; Looks good to me, approved diff --git a/tests/gem5/gem5_library_example_tests/test_gem5_library_examples.py b/tests/gem5/gem5_library_example_tests/test_gem5_library_examples.py index 7db46b0..e43d461 100644 --- a/tests/gem5/gem5_library_example_tests/test_gem5_library_examples.py +++ b/tests/gem5/gem5_library_example_tests/test_gem5_library_examples.py @@ -325,56 +325,59 @@ length=constants.very_long_tag, ) -gem5_verify_config( - name="test-gem5-library-create-looppoint-checkpoints", - fixtures=(), - verifiers=(), - config=joinpath( - config.base_dir, - "configs", - "example", - "gem5_library", - "looppoints", - "create-looppoint-checkpoint.py", - ), - config_args=[ - "--checkpoint-path", - joinpath(resource_path, "looppoint-checkpoint-save"), - ], - valid_isas=(constants.all_compiled_tag,), - valid_hosts=constants.supported_hosts, - length=constants.very_long_tag, -) +# The LoopPoint-Checkpointing feature is still under development, therefore +# these tests are temporarily disabled until this feature is complete.# -for region in ( - "1", - "2", - "3", - "5", - "6", - "7", - "8", - "9", - "10", - "11", - "12", - "13", - "14", -): - gem5_verify_config( - name=f"test-gem5-library-restore-looppoint-checkpoint-region-f{region}", - fixtures=(), - verifiers=(), - config=joinpath( - config.base_dir, - "configs", - "example", - "gem5_library", - "looppoints", - "restore-looppoint-checkpoint.py", - ), - config_args=["--checkpoint-region", region], - valid_isas=(constants.all_compiled_tag,), - valid_hosts=constants.supported_hosts, - length=constants.very_long_tag, - ) +# gem5_verify_config( +# name="test-gem5-library-create-looppoint-checkpoints", +# fixtures=(), +# verifiers=(), +# config=joinpath( +# config.base_dir, +# "configs", +# "example", +# "gem5_library", +# "looppoints", +# "create-looppoint-checkpoint.py", +# ), +# config_args=[ +# "--checkpoint-path", +# joinpath(resource_path, "looppoint-checkpoint-save"), +# ], +# valid_isas=(constants.all_compiled_tag,), +# valid_hosts=constants.supported_hosts, +# length=constants.very_long_tag, +# ) + +# for region in ( +# "1", +# "2", +# "3", +# "5", +# "6", +# "7", +# "8", +# "9", +# "10", +# "11", +# "12", +# "13", +# "14", +# ): +# gem5_verify_config( +# name=f"test-gem5-library-restore-looppoint-checkpoint-region-f{region}", +# fixtures=(), +# verifiers=(), +# config=joinpath( +# config.base_dir, +# "configs", +# "example", +# "gem5_library", +# "looppoints", +# "restore-looppoint-checkpoint.py", +# ), +# config_args=["--checkpoint-region", region], +# valid_isas=(constants.all_compiled_tag,), +# valid_hosts=constants.supported_hosts, +# length=constants.very_long_tag, +# ) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/69240?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I2c16abdaec639120c0ba349d90f5cc2fe747f8e6 Gerrit-Change-Number: 69240 Gerrit-PatchSet: 3 Gerrit-Owner: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: Jason Lowe-Power <power.jg@gmail.com> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com> Gerrit-MessageType: merged