gem5-dev@gem5.org

The gem5 Developer List

View all threads

[XS] Change in gem5/gem5[develop]: configs: Use higher dmesg level for GPUFS

MP
Matthew Poremba (Gerrit)
Sat, Apr 22, 2023 12:48 AM

Matthew Poremba has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/69977?usp=email )

Change subject: configs: Use higher dmesg level for GPUFS
......................................................................

configs: Use higher dmesg level for GPUFS

The dmesg level is currently set to 3 which will not display errors if
the amdgpu driver fails to load. Changing to level 8 will show errors in
the gem5 terminal and is not too spammy. This will help GPUFS developers
with bug reports since we would actually be able to observe an error.
Currently if the driver fails to load, there is no way to detect it and
applications will attempt to run, usually failing on getting device
properties.

Change-Id: I56b9581c1a12a8ce329066d18d6a072d006c096d
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/69977
Tested-by: kokoro noreply+kokoro@google.com
Reviewed-by: Matt Sinclair mattdsinclair@gmail.com
Maintainer: Matt Sinclair mattdsinclair@gmail.com

M configs/example/gpufs/hip_cookbook.py
M configs/example/gpufs/hip_rodinia.py
M configs/example/gpufs/hip_samples.py
M configs/example/gpufs/vega10_kvm.py
4 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
Matt Sinclair: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass

diff --git a/configs/example/gpufs/hip_cookbook.py
b/configs/example/gpufs/hip_cookbook.py
index 87c7547..6a7bb42 100644
--- a/configs/example/gpufs/hip_cookbook.py
+++ b/configs/example/gpufs/hip_cookbook.py
@@ -42,7 +42,7 @@
cookbook_runscript = """
export LD_LIBRARY_PATH=/opt/rocm/lib:$LD_LIBRARY_PATH
export HSA_ENABLE_INTERRUPT=0
-dmesg -n3
+dmesg -n8
dd if=/root/roms/vega10.rom of=/dev/mem bs=1k seek=768 count=128
if [ ! -f /lib/modules/uname -r/updates/dkms/amdgpu.ko ]; then
echo "ERROR: Missing DKMS package for kernel uname -r. Exiting gem5."
diff --git a/configs/example/gpufs/hip_rodinia.py
b/configs/example/gpufs/hip_rodinia.py
index 8ed951b..b8a7858 100644
--- a/configs/example/gpufs/hip_rodinia.py
+++ b/configs/example/gpufs/hip_rodinia.py
@@ -43,7 +43,7 @@
rodinia_runscript = """
export LD_LIBRARY_PATH=/opt/rocm/lib:$LD_LIBRARY_PATH
export HSA_ENABLE_INTERRUPT=0
-dmesg -n3
+dmesg -n8
dd if=/root/roms/vega10.rom of=/dev/mem bs=1k seek=768 count=128
if [ ! -f /lib/modules/uname -r/updates/dkms/amdgpu.ko ]; then
echo "ERROR: Missing DKMS package for kernel uname -r. Exiting gem5."
diff --git a/configs/example/gpufs/hip_samples.py
b/configs/example/gpufs/hip_samples.py
index ccc1719..9f83c25 100644
--- a/configs/example/gpufs/hip_samples.py
+++ b/configs/example/gpufs/hip_samples.py
@@ -42,7 +42,7 @@
samples_runscript = """
export LD_LIBRARY_PATH=/opt/rocm/lib:$LD_LIBRARY_PATH
export HSA_ENABLE_INTERRUPT=0
-dmesg -n3
+dmesg -n8
dd if=/root/roms/vega10.rom of=/dev/mem bs=1k seek=768 count=128
if [ ! -f /lib/modules/uname -r/updates/dkms/amdgpu.ko ]; then
echo "ERROR: Missing DKMS package for kernel uname -r. Exiting gem5."
diff --git a/configs/example/gpufs/vega10_kvm.py
b/configs/example/gpufs/vega10_kvm.py
index 54253be..9c7e457 100644
--- a/configs/example/gpufs/vega10_kvm.py
+++ b/configs/example/gpufs/vega10_kvm.py
@@ -44,7 +44,7 @@
demo_runscript = """
export LD_LIBRARY_PATH=/opt/rocm/lib:$LD_LIBRARY_PATH
export HSA_ENABLE_INTERRUPT=0
-dmesg -n3
+dmesg -n8
dd if=/root/roms/vega10.rom of=/dev/mem bs=1k seek=768 count=128
if [ ! -f /lib/modules/uname -r/updates/dkms/amdgpu.ko ]; then
echo "ERROR: Missing DKMS package for kernel uname -r. Exiting gem5."

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/69977?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-MessageType: merged
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I56b9581c1a12a8ce329066d18d6a072d006c096d
Gerrit-Change-Number: 69977
Gerrit-PatchSet: 2
Gerrit-Owner: Matthew Poremba matthew.poremba@amd.com
Gerrit-Reviewer: Jason Lowe-Power jason@lowepower.com
Gerrit-Reviewer: Matt Sinclair mattdsinclair@gmail.com
Gerrit-Reviewer: Matthew Poremba matthew.poremba@amd.com
Gerrit-Reviewer: kokoro noreply+kokoro@google.com

Matthew Poremba has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/69977?usp=email ) Change subject: configs: Use higher dmesg level for GPUFS ...................................................................... configs: Use higher dmesg level for GPUFS The dmesg level is currently set to 3 which will not display errors if the amdgpu driver fails to load. Changing to level 8 will show errors in the gem5 terminal and is not too spammy. This will help GPUFS developers with bug reports since we would actually be able to observe an error. Currently if the driver fails to load, there is no way to detect it and applications will attempt to run, usually failing on getting device properties. Change-Id: I56b9581c1a12a8ce329066d18d6a072d006c096d Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/69977 Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Matt Sinclair <mattdsinclair@gmail.com> Maintainer: Matt Sinclair <mattdsinclair@gmail.com> --- M configs/example/gpufs/hip_cookbook.py M configs/example/gpufs/hip_rodinia.py M configs/example/gpufs/hip_samples.py M configs/example/gpufs/vega10_kvm.py 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Matt Sinclair: Looks good to me, approved; Looks good to me, approved kokoro: Regressions pass diff --git a/configs/example/gpufs/hip_cookbook.py b/configs/example/gpufs/hip_cookbook.py index 87c7547..6a7bb42 100644 --- a/configs/example/gpufs/hip_cookbook.py +++ b/configs/example/gpufs/hip_cookbook.py @@ -42,7 +42,7 @@ cookbook_runscript = """\ export LD_LIBRARY_PATH=/opt/rocm/lib:$LD_LIBRARY_PATH export HSA_ENABLE_INTERRUPT=0 -dmesg -n3 +dmesg -n8 dd if=/root/roms/vega10.rom of=/dev/mem bs=1k seek=768 count=128 if [ ! -f /lib/modules/`uname -r`/updates/dkms/amdgpu.ko ]; then echo "ERROR: Missing DKMS package for kernel `uname -r`. Exiting gem5." diff --git a/configs/example/gpufs/hip_rodinia.py b/configs/example/gpufs/hip_rodinia.py index 8ed951b..b8a7858 100644 --- a/configs/example/gpufs/hip_rodinia.py +++ b/configs/example/gpufs/hip_rodinia.py @@ -43,7 +43,7 @@ rodinia_runscript = """\ export LD_LIBRARY_PATH=/opt/rocm/lib:$LD_LIBRARY_PATH export HSA_ENABLE_INTERRUPT=0 -dmesg -n3 +dmesg -n8 dd if=/root/roms/vega10.rom of=/dev/mem bs=1k seek=768 count=128 if [ ! -f /lib/modules/`uname -r`/updates/dkms/amdgpu.ko ]; then echo "ERROR: Missing DKMS package for kernel `uname -r`. Exiting gem5." diff --git a/configs/example/gpufs/hip_samples.py b/configs/example/gpufs/hip_samples.py index ccc1719..9f83c25 100644 --- a/configs/example/gpufs/hip_samples.py +++ b/configs/example/gpufs/hip_samples.py @@ -42,7 +42,7 @@ samples_runscript = """\ export LD_LIBRARY_PATH=/opt/rocm/lib:$LD_LIBRARY_PATH export HSA_ENABLE_INTERRUPT=0 -dmesg -n3 +dmesg -n8 dd if=/root/roms/vega10.rom of=/dev/mem bs=1k seek=768 count=128 if [ ! -f /lib/modules/`uname -r`/updates/dkms/amdgpu.ko ]; then echo "ERROR: Missing DKMS package for kernel `uname -r`. Exiting gem5." diff --git a/configs/example/gpufs/vega10_kvm.py b/configs/example/gpufs/vega10_kvm.py index 54253be..9c7e457 100644 --- a/configs/example/gpufs/vega10_kvm.py +++ b/configs/example/gpufs/vega10_kvm.py @@ -44,7 +44,7 @@ demo_runscript = """\ export LD_LIBRARY_PATH=/opt/rocm/lib:$LD_LIBRARY_PATH export HSA_ENABLE_INTERRUPT=0 -dmesg -n3 +dmesg -n8 dd if=/root/roms/vega10.rom of=/dev/mem bs=1k seek=768 count=128 if [ ! -f /lib/modules/`uname -r`/updates/dkms/amdgpu.ko ]; then echo "ERROR: Missing DKMS package for kernel `uname -r`. Exiting gem5." -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/69977?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-MessageType: merged Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I56b9581c1a12a8ce329066d18d6a072d006c096d Gerrit-Change-Number: 69977 Gerrit-PatchSet: 2 Gerrit-Owner: Matthew Poremba <matthew.poremba@amd.com> Gerrit-Reviewer: Jason Lowe-Power <jason@lowepower.com> Gerrit-Reviewer: Matt Sinclair <mattdsinclair@gmail.com> Gerrit-Reviewer: Matthew Poremba <matthew.poremba@amd.com> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com>